Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hot reload crash in homepage #30

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

limwa
Copy link
Member

@limwa limwa commented Jan 5, 2025

When changing code and the homepage would hot reload, the page would be blank after the reload. This is because AbortController is a class and, as such, if a method from it is destructured, the method also needs to be bound to the instance of the class.

@limwa limwa force-pushed the fix/hot-reload-crash-in-homepage branch from f3910a3 to 5c4a597 Compare January 5, 2025 20:17
@limwa limwa force-pushed the fix/hot-reload-crash-in-homepage branch from 5c4a597 to 444a6a1 Compare January 5, 2025 20:20
@limwa limwa requested a review from a team January 7, 2025 04:35
@limwa limwa merged commit b24f8b5 into main Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants