Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret management with Vault #58

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Secret management with Vault #58

wants to merge 7 commits into from

Conversation

tomaspalma
Copy link
Member

@tomaspalma tomaspalma commented Jun 5, 2024

Closes #28

@tomaspalma tomaspalma self-assigned this Jun 5, 2024
@LuisDuarte1 LuisDuarte1 self-requested a review June 5, 2024 14:18
@tomaspalma tomaspalma marked this pull request as ready for review June 5, 2024 15:08
@tomaspalma tomaspalma force-pushed the feature/vault branch 2 times, most recently from e13a9f2 to c392249 Compare June 21, 2024 14:45

ui:
enabled: true
serviceType: "LoadBalancer"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be ClusterIP?

apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
name: trust-manager-example-ca
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this certificate used for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle K8S secrets properly
2 participants