Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/auth #54
Feature/auth #54
Changes from all commits
55db4c7
a9410dd
c104c75
cd36af3
c5ff3f2
4128f2c
88e9b76
edc8ff1
5a0f2e2
a335f95
f98fb20
a9bc564
fc4df18
9573812
550d5a4
cdf62b6
cdd5b5f
b897bc0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should think about how we want to store these DTOs. Until now, we only used DTOs that directly match our models so they're in the
model/
package. However, this is not the case here.I don't have a solution right now so I'll leave some food for thought. Should we keep all DTOs/DAOs in their own package and rename our current
Dto
abstract class toModelDto
or something of sorts? Or should we keep our current implementation and just move these new type of Dtos to their own package?Please let em know what you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do like this:
Should I do this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that as well. I think we should do it here, so we don't merge code that's going to change immediately