-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File metadata start #45
Conversation
Deployment will fail right now because a number of Reference fields are not connected to an actual resource elsewhere. We could create artificial connections to other examples in the IG but they might not be the best way to construct the examples-- open to suggestions on how to handle the Reference issues! |
🚀 IG Site Preview DeployedLatest commit: 2e23e8b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you add | focus | 1..1 | Reference(...)| to each of those as a note someplace to make it easier to remember where that goes so the implementers don't have to click on an additional link to find it?
input/fsh/examples/file-metadata.fsh
Outdated
Title: "Example file metadata for a FASTQ file" | ||
Usage: #example | ||
Description: "Example file metadata for a FASTQ file" | ||
* focus = Reference(ParentFile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is parent file an actual NCPI File? This should point to a fhir resource based on the profile NCPI File.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. My only concern is that your tables don't include all enumerations (I don't think) which is what I understood Robert to have asked for. However, for a start this is fine. It does make sense that we get his eyes on it before we call it ready for presentation to NIH or whomever it is he'll be presenting to at the end of the month.
Motivation
This is a start to the File Metadata profile to illustrate the way in which profiles build on each other but does not include all file types and focuses mainly on handling FASTQ, BAM/CRAM, and VCF/gVCF file metadata information.
Approach
Progressively specific profiles build on one another with optional elements that can be added or omitted from describing a file.