Add Port from chassis config file #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osinstom
requested changes
Oct 2, 2023
.gitignore
Outdated
| @@ -65,3 +65,6 @@ __pycache__/ | |||
| # SSL certificates | |||
| tools/tls/certs/ | |||
| .srl | |||
|
|
|||
| /bb.sh | |||
script.py
Outdated
| @@ -0,0 +1,5 @@ | |||
| from scapy.all import * | |||
There was a problem hiding this comment.
I don't think this script should be pushed to the repo, I'm assuming it's used for testing only?
setup.sh
Outdated
| @@ -0,0 +1,29 @@ | |||
| #!/usr/bin/env bash | |||
setup_dev_env.sh
Outdated
| @@ -136,4 +136,5 @@ if [ "$NP4_INTEL" == YES ]; then | |||
| DOCKER_RUN_OPTIONS="$DOCKER_RUN_OPTIONS -v /dev/intel-fpga-fme.0:/dev/intel-fpga-fme.0" | |||
| fi | |||
| DOCKER_RUN_OPTIONS="$DOCKER_RUN_OPTIONS $@" | |||
|
|
|||
| chassis_config[node_id][port.port_id] = port; | ||
| } | ||
|
|
||
| /* |
| if (nikss_pipeline_exists(ctx.get())) { | ||
| LOG(INFO) << "NIKSS pipeline already exists, re-pushing is not supported yet."; | ||
| return ::util::OkStatus(); | ||
| } | ||
|
|
||
| // FIXME: file is not removed if the load() fails |
There was a problem hiding this comment.
I think we can postpone this for later PR because it is not critical for now
|
Done |
osinstom
requested changes
Nov 6, 2023
Dockerfile
Outdated
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| FROM stratumproject/build:build | |||
|
|
|||
| ARG USER_NAME=stratum | |||
There was a problem hiding this comment.
Why do we change the default username?
script.py
Outdated
| @@ -0,0 +1,5 @@ | |||
| from scapy.all import * | |||
setup.sh
Outdated
| @@ -0,0 +1,29 @@ | |||
| #!/usr/bin/env bash | |||
stratum/hal/bin/nikss/main.cc
Outdated
| @@ -68,4 +68,4 @@ ::util::Status Main(int argc, char* argv[]) { | |||
|
|
|||
| int main(int argc, char* argv[]) { | |||
| return stratum::hal::nikss::Main(argc, argv).error_code(); | |||
| } | |||
| } | |||
| return ::util::OkStatus(); | ||
| } | ||
|
|
||
| /* |
|
This should fix it. The previous commit was made by mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.