Skip to content

Commit

Permalink
fix 36-2 trigger params (rusefi#4138)
Browse files Browse the repository at this point in the history
* fix gap params

* changelog was wrong too

* typo

* binary log knock count and retard

* Revert "binary log knock count and retard"

This reverts commit 48b29d2.
  • Loading branch information
mck1117 authored May 5, 2022
1 parent 46acfb1 commit 045cbcb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion firmware/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Release template (copy/paste this for new release):
- ETB low limit is now configurable #4119

### Fixed
- 36-1 trigger gaps #4132
- Make 36-2 trigger sync parameters more generous #4132

## April 20202 Release - "Day 58"

Expand Down
5 changes: 2 additions & 3 deletions firmware/controllers/trigger/decoders/trigger_structure.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,8 @@ void TriggerWaveform::initializeTriggerWaveform(operation_mode_e triggerOperatio

case TT_TOOTHED_WHEEL_36_2:
setToothedWheelConfiguration(this, 36, 2, triggerOperationMode);
setSecondTriggerSynchronizationGap(1); // this gap is not required to synch on perfect signal but is needed to handle to reject cranking transition noise
setTriggerSynchronizationGap3(/*gapIndex*/0, /*from*/1.6, 3.5);
setTriggerSynchronizationGap3(/*gapIndex*/1, /*from*/0.7, 1.3); // second gap is not required to synch on perfect signal but is needed to handle to reject cranking transition noise
break;

case TT_60_2_VW:
Expand All @@ -646,8 +647,6 @@ void TriggerWaveform::initializeTriggerWaveform(operation_mode_e triggerOperatio

case TT_TOOTHED_WHEEL_36_1:
setToothedWheelConfiguration(this, 36, 1, triggerOperationMode);
setTriggerSynchronizationGap3(/*gapIndex*/0, /*from*/1.9, 3.5);
setTriggerSynchronizationGap3(/*gapIndex*/1, /*from*/0.7, 1.3); // second gap is not required to synch on perfect signal but is needed to handle to reject cranking transition noise
break;

case TT_VVT_BOSCH_QUICK_START:
Expand Down

0 comments on commit 045cbcb

Please sign in to comment.