-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove completely kinematics_override #2266
Conversation
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this (especially for fixing the remaining quirks of the old re-implemented sets)!!
So when would the k_
be completely stripped out of the codes? And do you perhaps happen to have a comparison of the kinematic plots?
yes, the Regarding the plots, I do have comparisons for the entire set of data. imho when they have changed they look better but I don't want to clutter the server too much, as a surrogate you can look at this comparisons between this comparefit: https://vp.nnpdf.science/a0kifkAWSlSTtrwUa7KqbQ== and this older one: https://vp.nnpdf.science/eB5jnBi4Qn-OEc2KCq_i1g== (if you want to look at the whole set of changes I can upload them to the server) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cleaner!!
Okok, good!
As far as I can tell, everything looks good.
Maybe even just for the record, this is good to have on the server in any case. |
I put them in |
7ff2738
to
698521b
Compare
This PR closes #2252, which has required datasets that either have only legacy version or for which it was just not done during the translation.
For HERA data in particular the situation was a bit dire since the plots reported Q2 but the numbers were actually Q. Now it should be Q2 everywhere, which might not be what everybody wants, but at least is correct.
The same is true for the NMC (with a horrible result, but the previous situation was just silly so I've modified the kinematics for that) and NUTEV.
(personally I'd move all the squared quantities to just... not the square?)
Edit: the fecking NMC legacy dataset with kinematics done with a dice had of course to be part of every single regression test 🤷 I hope we can move to the hepdata-binned version.