Implement dataset name changes to tech doc #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed all occurrences of the old dataset name to the new dataset name
Changed occurrences of old dataset name to new dataset name
Changed occurrences of old dataset name to new dataset name
Changed occurrences of old dataset name to new dataset name
Changed: - `bottom_temp_ to `bottom_temp_insitu` - `HMS_species_distribution` to `cetacean_dist` - `seasonal_sst_anomaly_gridded` to `seasonal_oisst_anom_gridded`
|
This pull also fixes #121 |
sgaichas
requested changes
Nov 18, 2024
There was a problem hiding this comment.
This does build locally for me; however a couple things are missing:
Missing reference sections (Doesn't look like this is new in this PR, so not a result of the name changes)
- Bottom temperature in situ
- Cetacean distribution shifts
I think we need a new tech doc page or pages for the thermal habitat indicators. The other page linked under legacy is a separate analysis.
|
Thanks Sarah, I'll take a look at the missing references. I also noticed the missing thermal habitat page(s) but wasn't sure about the legacy page. Thanks for clarifying. @jcaracappa1 I looked through your submissions from last year and didn't see a tech doc page for thermal habitat. Do you remember sending in methods information for the thermal habitat indicators? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace data names that have been changed in ecodata.
Renamed tech doc pages and replaced links to catalog to account for recent data name changes.
Note:
bottom_temp_model_anomandthermal_habitat_griddeddo not currently have linked tech doc pages. @jcaracappa1 should the thermal habitat products link to this Thermal Habitat Projections page? And does the Bottom Temp High Resolution page cover the methods for both of your bottom temp products?This pull requires 1 reviewer to verify that tech doc builds locally.