Skip to content

Commit

Permalink
Bugfix for ensemble recenter + add a test (#1477)
Browse files Browse the repository at this point in the history
# Description

Bugfix for ensemble recenter; adds a gw-ci test for recenter as well.

# Companion PRs

Required for NOAA-EMC/global-workflow#3238

# Automated CI tests to run in Global Workflow
<!-- Which Global Workflow CI tests are required to adequately test this
PR? -->
- [ ] atm_jjob <!-- JEDI atm single cycle DA !-->
- [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !-->
- [ ] C96C48_hybatmaerosnowDA  <!-- JEDI aero/snow cycled DA !-->
- [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !-->
- [x] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !-->
- [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->

Co-authored-by: Anna Shlyaeva <[email protected]>
  • Loading branch information
shlyaeva and Anna Shlyaeva authored Feb 5, 2025
1 parent fa09326 commit d300ebe
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion parm/soca/berror/soca_ensrecenter.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,5 @@ output increment:
date: '{{ MARINE_WINDOW_END_ISO }}'
exp: trash
type: incr
output file: 'ocn.recenter.incr.%mem%.nc'
output file: 'recenter.incr.%mem%.nc'
pattern: '%mem%'
4 changes: 4 additions & 0 deletions test/gw-ci/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,9 @@ function(add_task task_name test_prefix is_full_cycle HALF_CYCLE FULL_CYCLE pslo
elseif("${task_name}" STREQUAL "gdas_marineanlletkf")
list(APPEND TEST_DEPENDS "${test_prefix}_enkfgdas_fcst_${HALF_CYCLE}")
list(APPEND TEST_DEPENDS "${test_prefix}_gdas_prepoceanobs_${FULL_CYCLE}")
elseif("${task_name}" STREQUAL "gdas_ocnanalecen")
list(APPEND TEST_DEPENDS "${test_prefix}_gdas_marineanlvar_${FULL_CYCLE}")
list(APPEND TEST_DEPENDS "${test_prefix}_gdas_marineanlletkf_${FULL_CYCLE}")
else()
list(APPEND TEST_DEPENDS "${test_prefix}")
endif()
Expand Down Expand Up @@ -394,6 +397,7 @@ if (WORKFLOW_TESTS)
"gdas_marinebmat"
"gdas_marineanlinit"
"gdas_marineanlvar"
"gdas_ocnanalecen"
"gdas_marineanlchkpt"
"gdas_marineanlfinal"
)
Expand Down
2 changes: 1 addition & 1 deletion utils/soca/gdas_ens_handler.h
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ namespace gdasapp {
postProcIncr.setToZero(incr);

// Save the increments used to initialize the ensemble forecast
result = postProcIncr.save(mom6_incr, i+1);
result = postProcIncr.save(mom6_incr, i+1, {"ocn"});
}
return result;
}
Expand Down

0 comments on commit d300ebe

Please sign in to comment.