Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sea ice recentering #1478

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Add sea ice recentering #1478

merged 2 commits into from
Feb 7, 2025

Conversation

guillaumevernieres
Copy link
Contributor

@guillaumevernieres guillaumevernieres commented Feb 6, 2025 •
edited
Loading

@guillaumevernieres guillaumevernieres self-assigned this Feb 6, 2025
@guillaumevernieres guillaumevernieres added the hercules-GW-RT Queue for automated testing with global-workflow on Hercules label Feb 6, 2025
@emcbot emcbot added hercules-GW-RT-Running Automated testing with global-workflow running on Hercules and removed hercules-GW-RT Queue for automated testing with global-workflow on Hercules labels Feb 6, 2025
@emcbot
Copy link

emcbot commented Feb 6, 2025

Automated GW-GDASApp Testing Results:
Machine: hercules

Start: Thu Feb  6 12:34:10 CST 2025 on hercules-login-1.hpc.msstate.edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Feb  6 13:09:45 CST 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C48mx500_3DVarAOWCDA|C48mx500_hybAOWCDA|C96C48_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Thu Feb  6 13:10:37 CST 2025
Tests: 100% tests passed, 0 tests failed out of 32

@emcbot emcbot added hercules-GW-RT-Passed Automated testing with global-workflow successful on Hercules and removed hercules-GW-RT-Running Automated testing with global-workflow running on Hercules labels Feb 6, 2025
@shlyaeva @guillaumevernieres
Add sea ice recentering (#1479)
be41879 
# Description

Adds recentering for sea ice by adding the recentering increment to the
sea ice background, and calling Soca2Cice variable change.

Requires copying background files and ice restarts, I wasn't familiar
with how to code this, so please review.

# Companion PRs

Needs a change to global-workflow as well:
guillaumevernieres/global-workflow#10

# Issues

Resolves #1454 

# Automated CI tests to run in Global Workflow
<!-- Which Global Workflow CI tests are required to adequately test this
PR? -->
- [ ] atm_jjob <!-- JEDI atm single cycle DA !-->
- [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !-->
- [ ] C96C48_hybatmaerosnowDA  <!-- JEDI aero/snow cycled DA !-->
- [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !-->
- [x] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !-->
- [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->

---------

Co-authored-by: Anna Shlyaeva <[email protected]>
Co-authored-by: Guillaume Vernieres <[email protected]>
@guillaumevernieres guillaumevernieres added hercules-GW-RT Queue for automated testing with global-workflow on Hercules and removed hercules-GW-RT-Passed Automated testing with global-workflow successful on Hercules labels Feb 6, 2025
@emcbot emcbot added hercules-GW-RT-Running Automated testing with global-workflow running on Hercules and removed hercules-GW-RT Queue for automated testing with global-workflow on Hercules labels Feb 6, 2025
@emcbot
Copy link

emcbot commented Feb 6, 2025

Automated GW-GDASApp Testing Results:
Machine: hercules

Start: Thu Feb  6 16:05:12 CST 2025 on hercules-login-1.hpc.msstate.edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Feb  6 16:40:47 CST 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C48mx500_3DVarAOWCDA|C48mx500_hybAOWCDA|C96C48_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Thu Feb  6 16:41:31 CST 2025
Tests: 100% tests passed, 0 tests failed out of 32

@emcbot emcbot added hercules-GW-RT-Passed Automated testing with global-workflow successful on Hercules and removed hercules-GW-RT-Running Automated testing with global-workflow running on Hercules labels Feb 6, 2025
@guillaumevernieres guillaumevernieres marked this pull request as ready for review February 7, 2025 13:21
@guillaumevernieres guillaumevernieres changed the title Dummy commit for PR testing Add sea ice recentering Feb 7, 2025
shlyaeva
shlyaeva approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@shlyaeva shlyaeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so well done 😆

AndrewEichmann-NOAA
AndrewEichmann-NOAA approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine - I had forgotten I had written the original script a year ago!

@guillaumevernieres guillaumevernieres merged commit 7b90ef7 into develop Feb 7, 2025
11 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/lowres-b branch February 7, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlyaeva shlyaeva shlyaeva approved these changes

@AndrewEichmann-NOAA AndrewEichmann-NOAA AndrewEichmann-NOAA approved these changes

Assignees

@guillaumevernieres guillaumevernieres

Labels
hercules-GW-RT-Passed Automated testing with global-workflow successful on Hercules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recenter sea ice ensembles
4 participants
@guillaumevernieres @emcbot @shlyaeva @AndrewEichmann-NOAA