Add sea ice recentering #1479
Merged
Add sea ice recentering #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlyaeva
commented
Feb 6, 2025
ush/soca/marine_recenter.py
Outdated
Comment on lines
187
to
192
| fname_in = os.path.abspath(os.path.join(mem_dir_real, f00)) | ||
| fname_out = os.path.realpath(os.path.join(self.task_config.ens_dir, | ||
| "cice_model.res."+str(mem)+".nc")) | ||
| ens_cice_list.append([fname_in, fname_out]) | ||
| fname_out = os.path.realpath(os.path.join(self.task_config.ens_dir, | ||
| "cice_model.res.output."+str(mem)+".nc")) |
There was a problem hiding this comment.
Note: this currently copies restarts twice (to keep input and output separate), we can change this before the merge to only copy the file once, and change it in place. (I coded input and output separately so I can easily see what the recentering does).
shlyaeva
commented
Feb 6, 2025
Comment on lines
+53
to
+67
| variable change name: Soca2Cice | ||
| arctic: | ||
| seaice edge: 0.4 | ||
| shuffle: true | ||
| rescale prior: | ||
| rescale: true | ||
| min hice: 0.5 | ||
| min hsno: 0.1 | ||
| antarctic: | ||
| seaice edge: 0.4 | ||
| shuffle: true | ||
| rescale prior: | ||
| rescale: true | ||
| min hice: 0.5 | ||
| min hsno: 0.1 |
There was a problem hiding this comment.
note: these parameters should be the same as in soca2cice used in the marineanlckpt; ideally we would reference the same yaml section in both places.
|
After one cycle (once the deterministic background includes the large analysis increment from the previous cycle): |
guillaumevernieres
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds recentering for sea ice by adding the recentering increment to the sea ice background, and calling Soca2Cice variable change.
Requires copying background files and ice restarts, I wasn't familiar with how to code this, so please review.
Companion PRs
Needs a change to global-workflow as well: guillaumevernieres/global-workflow#10
Issues
Resolves #1454
Automated CI tests to run in Global Workflow