Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sp into ip #210

Merged

Conversation

AlexanderRichert-NOAA
Copy link
Contributor

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Nov 3, 2023

This PR merges NCEPLIBS-sp into NCEPLIBS-ip so that the NCEPLIBS-sp repo can be retired.

Summary:

  • All of the sp source code is integrated into the ip library, but currently not through a module interface. That way, developers should be able to use it right away without code modification. In the next release, I'll create an sp_mod module for consistency with the rest of the library.
  • Tests all merged. In the next version I'll rebuild the baseline files or tweak the test code so we don't need the big endian flags for the sp tests.
  • No more sp in the CI (or cmake, of course).
  • Removed -fimplicit-none for GCC; plan to restore in next version (requires significant code changes).
  • Disabling bounds checking for a few sp files; plan to do away with this in next version (requires significant code changes).
  • Updated spack recipe.
  • Merged and updated documentation.
  • VERSION -> 5.0.0

Unrelated to the sp merge:

  • Fixed a bug that was causing issues for building tests with multiple make threads.
  • Simplified spack CI to reduce number of jobs.
  • Misc. README/LICENSE updates.

Verification:

  • Code coverage: The new code is getting checked and everything looks right.
  • Spack: The updated recipe concretizes, builds, and tests successfully using the latest spack.
  • Test run time: the develop job takes significantly longer to run, probably because the sp code is no longer being optimized. I'll create an issue for this (either optimize code or split up the work).

Fixes #93
Fixes #209

@edwardhartnett
Copy link
Contributor

Awesome!

Copy link
Contributor

@edwardhartnett edwardhartnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@AlexanderRichert-NOAA AlexanderRichert-NOAA merged commit cfbcd25 into NOAA-EMC:develop Jan 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix parallel builds when BUILD_TESTING=ON Combine the NCEPLIBS-sp code with this repo
2 participants