-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge sp into ip #210
Merged
AlexanderRichert-NOAA
merged 35 commits into
NOAA-EMC:develop
from
AlexanderRichert-NOAA:merge_sp_nov2023
Jan 23, 2024
Merged
Merge sp into ip #210
AlexanderRichert-NOAA
merged 35 commits into
NOAA-EMC:develop
from
AlexanderRichert-NOAA:merge_sp_nov2023
Jan 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awesome! |
This reverts commit 7f9f5bf.
AlexanderRichert-NOAA
force-pushed
the
merge_sp_nov2023
branch
from
November 3, 2023 21:44
b6aa034
to
f202411
Compare
AlexanderRichert-NOAA
force-pushed
the
merge_sp_nov2023
branch
from
November 7, 2023 19:06
f1d1394
to
64f4a9a
Compare
AlexanderRichert-NOAA
requested review from
edwardhartnett and
EricEngle-NOAA
November 7, 2023 22:44
edwardhartnett
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges NCEPLIBS-sp into NCEPLIBS-ip so that the NCEPLIBS-sp repo can be retired.
Summary:
-fimplicit-none
for GCC; plan to restore in next version (requires significant code changes).Unrelated to the sp merge:
Verification:
Fixes #93
Fixes #209