Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20241212 Jesse Meng add Utah SLR 2024 algorithm #1104

Merged
merged 6 commits into from
Dec 23, 2024

Conversation

JesseMeng-NOAA
Copy link
Contributor

@JesseMeng-NOAA JesseMeng-NOAA commented Dec 12, 2024

Add Utah SLR 2024 algorithm.

@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Dec 16, 2024
@WenMeng-NOAA
Copy link
Collaborator

@JesseMeng-NOAA From the UPP RTs on Hera, your PR impacts on the field "SDEN" in the tests for gfs, fv3r and 3drtma. I assume these are expected changes. Please take a look at /home/Wen.Meng/stmp2/UPP-RTs/fv3gfs_2019083000 and /home/Wen.Meng/stmp2/UPP-RTs/fv3r_2023062800 and let me know if you see issues.

@WenMeng-NOAA WenMeng-NOAA linked an issue Dec 17, 2024 that may be closed by this pull request
@JesseMeng-NOAA
Copy link
Contributor Author

@JesseMeng-NOAA From the UPP RTs on Hera, your PR impacts on the field "SDEN" in the tests for gfs, fv3r and 3drtma. I assume these are expected changes. Please take a look at /home/Wen.Meng/stmp2/UPP-RTs/fv3gfs_2019083000 and /home/Wen.Meng/stmp2/UPP-RTs/fv3r_2023062800 and let me know if you see issues.

Results look reasonable. Thanks.

@WenMeng-NOAA
Copy link
Collaborator

@JesseMeng-NOAA Please add a change log in MDL2P.f

@JesseMeng-NOAA
Copy link
Contributor Author

@JesseMeng-NOAA Please add a change log in MDL2P.f

Added.

@WenMeng-NOAA
Copy link
Collaborator

@gspetro-NOAA You may start the UPP RTs on R&D machines. Please refer my tests on Hera:

Wen.Meng@hfe03 UPP-RTs$ pwd
/home/Wen.Meng/stmp2/UPP-RTs
Wen.Meng@hfe03 UPP-RTs$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp    75 Dec 17 16:27 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp 14011 Dec 17 16:29 rtma_2023040400_pe_test/NATLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 13861 Dec 17 16:30 fv3r_2023062800/NATLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 13861 Dec 17 16:30 fv3r_2023062800_pe_test/NATLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14011 Dec 17 16:32 rtma_2023040400/NATLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  3449 Dec 17 16:35 fv3gfs_2019083000/gfs.t00z.master.grb2f006.diff
-rw-r--r-- 1 Wen.Meng stmp  3449 Dec 17 16:36 fv3gfs_2019083000_pe_test/gfs.t00z.master.grb2f006.diff

I will conduct the RTs on WCOSS2 next week when WCOSS2 is back.

@WenMeng-NOAA WenMeng-NOAA added the Baseline Change The baselines of the UPP regression tests are changed. label Dec 17, 2024
@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs have been completed on WCOSS2. The baseline recreations are needed for gfs, fv3r and 3drtma with this PR.

@gspetro-NOAA
Copy link
Collaborator

Tests pass on Hera, Orion, and Hercules with the expected baseline changes.

@WenMeng-NOAA
Copy link
Collaborator

@gspetro-NOAA Please approve this PR.

@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 51f5ad1 into NOAA-EMC:develop Dec 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Change The baselines of the UPP regression tests are changed. GFSV17 Ready for commit queue Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition the updated U Utah SLR algorithm to UPP
3 participants