Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load cmake on wcoss2 at build time #1107

Merged

Conversation

aerorahul
Copy link
Contributor

This PR enables loading of cmake on wcoss2 at build time.
Resolves #1106

For additional information, please look at the conversations in NOAA-EMC/global-workflow#3186

@aerorahul aerorahul changed the title Load cmake on wcoss2 at build time, this was missing. Load cmake on wcoss2 at build time Dec 31, 2024
Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ran a test build on a Dogwood compute node (nid002177).

Just a note that the UPP has been upgraded to spack-stack 1.8.0, so to bring this into the workflow, we will need to upgrade other packages to 1.8.0 or load UPP modules at runtime instead of module_base.

@aerorahul
Copy link
Contributor Author

Just a note that the UPP has been upgraded to spack-stack 1.8.0, so to bring this into the workflow, we will need to upgrade other packages to 1.8.0 or load UPP modules at runtime instead of module_base.

That is a bummer!

@WenMeng-NOAA WenMeng-NOAA added enhancement New feature or request Ready for Review This PR is ready for code review. Ready for commit queue labels Jan 3, 2025
@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs have completed on WCOSS2 without baseline changes. Testing on R&D machines is unnecessary since this PR is specific to WCOSS2. This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit ba33937 into NOAA-EMC:develop Jan 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Ready for commit queue Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load a Cmake module on WCOSS2
3 participants