Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RRFS–MPAS: Add the U. Utah SLR field ("SDEN") #1132

Merged
merged 6 commits into from
Feb 4, 2025

Conversation

jaymes-kenyon
Copy link
Contributor

@jaymes-kenyon jaymes-kenyon commented Feb 4, 2025

[Re-attempt of previous PR #1130, which was closed]

This PR addresses issue #1125.

Specifically, it adds the University of Utah snow-to-liquid ratio (SLR) diagnostic output to RRFS–MPAS applications, yielding a GRIB2 field abbreviated "SDEN". Recent development with this diagnostic occurred in the merged PR #1104; refer to that PR for more details.

Additionally, the current PR fixes an unrelated typo in code comments.

@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon @JesseMeng-NOAA My UPP standalone test for MPAS is at /home/Wen.Meng/stmp2/mpas_2024112100-after pn Hera. The new field "SDEN" was generated in WRFTWO dataset as:

wgrib2 WRFTWO12.tm00 -match SDEN -s -stats
40:36132094:d=2024112012:SDEN:surface:12 hour fcst::ndata=1905141:undef=1459740:mean=88.4948:min=45.653:max=679.477:cos_wt_mean=89.7173

Please let me know if you see issues in my test.

@WenMeng-NOAA
Copy link
Collaborator

@gspetro-NOAA You may start the UPP RTs on R&D machines. There should be no baseline changes with this PR.

@WenMeng-NOAA WenMeng-NOAA linked an issue Feb 4, 2025 that may be closed by this pull request
@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. Ready for commit queue No Baseline Change No baseline of the UPP regression tests are made. labels Feb 4, 2025
@jaymes-kenyon
Copy link
Contributor Author

@jaymes-kenyon @JesseMeng-NOAA My UPP standalone test for MPAS is at /home/Wen.Meng/stmp2/mpas_2024112100-after pn Hera. The new field "SDEN" was generated in WRFTWO dataset as:

wgrib2 WRFTWO12.tm00 -match SDEN -s -stats
40:36132094:d=2024112012:SDEN:surface:12 hour fcst::ndata=1905141:undef=1459740:mean=88.4948:min=45.653:max=679.477:cos_wt_mean=89.7173

Please let me know if you see issues in my test.

@WenMeng-NOAA — Thanks! Your test results look good to me. My own testing worked on Jet.

@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs have been completed on WCOSS2 with no baseline changes. This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit d1f6167 into NOAA-EMC:develop Feb 4, 2025
3 checks passed
Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTs pass on Hera, Orion, and Hercules with no baseline changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MPAS No Baseline Change No baseline of the UPP regression tests are made. Ready for commit queue Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RRFS–MPAS: Add U. Utah SLR diagnostic output
4 participants