-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable global-workflow to run C768C384 GSI on Gaea-C5 #2990
base: develop
Are you sure you want to change the base?
Conversation
Hi @aerorahul I've left this PR in draft form, since I know there will be some necessary changes. One being...I can't seem to increase WRTTASK_PER_GROUP_PER_THREAD_PER_TILE_{GDAS,GFS} and get it to update ntasks properly. I made the change in config.ufs but know it should be in config.resources.GAEA. Thanks for any suggestions! |
e8373d7
to
5c45bc9
Compare
98f5c19
to
569e388
Compare
fa84e39
to
7db0b48
Compare
Morning @DavidHuber-NOAA. Thanks for the suggestion in a second sourcing of config.resources. I gave it a try but noticed that ntasks_quilt for GDAS and GFS were not updating correctly on the second loop. I added the calculation of those variables to config.resources.GAEA as well, and that seems to do the trick. I reran the workflow successfully last night with the update. Please let me know your thoughts! Thanks |
(( WRTTASK_PER_GROUP_PER_THREAD_GDAS = WRTTASK_PER_GROUP_PER_THREAD_PER_TILE_GDAS * 6 )) | ||
(( WRTTASK_PER_GROUP_PER_THREAD_GFS = WRTTASK_PER_GROUP_PER_THREAD_PER_TILE_GFS * 6 )) | ||
export WRTTASK_PER_GROUP_PER_THREAD_GDAS | ||
export WRTTASK_PER_GROUP_PER_THREAD_GFS | ||
(( ntasks_quilt_gdas = WRITE_GROUP_GDAS * WRTTASK_PER_GROUP_PER_THREAD_GDAS )) | ||
(( ntasks_quilt_gfs = WRITE_GROUP_GFS * WRTTASK_PER_GROUP_PER_THREAD_GFS )) | ||
export ntasks_quilt_gdas | ||
export ntasks_quilt_gfs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aerorahul Since this is duplicating calculations from config.ufs, I wonder if these should be moved from config.ufs to config.resources OR if we should allow the basic variables (i.e. WRTTASK_PER_GROUP_PER_THREAD_PER_TILE_${RUN}
) to be predefined in config.ufs
. For instance, changing
global-workflow/parm/config/gfs/config.ufs
Lines 283 to 286 in a42c833
export WRITE_GROUP_GDAS=2 | |
export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE_GDAS=15 | |
export WRITE_GROUP_GFS=4 | |
export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE_GFS=20 #Note this should be 10 for WCOSS2 |
to
export WRITE_GROUP_GDAS=${WRITE_GROUP_GDAS:-2}
export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE_GDAS=${WRTTASK_PER_GROUP_PER_THREAD_PER_TILE_GDAS:-15}
export WRITE_GROUP_GFS=${WRITE_GROUP_GFS:-4}
export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE_GFS=${WRTTASK_PER_GROUP_PER_THREAD_PER_TILE_GFS:-20}
Then, instead of re-sourcing config.resources, Alex would re-source config.ufs, then config.resources, while only defining WRTTASK_PER_GROUP_PER_THREAD_PER_TILE_${RUN}
. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WalterKolczynski-NOAA as well ^^^.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Morning @WalterKolczynski-NOAA @aerorahul C5 is down probably through tomorrow (Wed) but just wanted to check if you had a chance to look at this. I think the less we have to calculate in config.resources.$MACH the better. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I favor the second approach of allowing overrides, but want to hear from @aerorahul
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidHuber-NOAA's recommendation makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @WalterKolczynski-NOAA and @aerorahul. Hello @DavidHuber-NOAA ...My hands are tied with the C5 OS upgrade, but I was looking through this and writing out all the steps..Everything looks good for your second option until the re-sourcing of config.ufs. In config.fcst, config.ufs is sourced via source "${EXPDIR}/config.ufs" ${string}
where string is configured based on which model components are used, i.e., ocn, ice, wave, etc. In order to get the string option into config.ufs, I believe I should re-source config.fcst which will do the re-sourcing of config.ufs. Let me know your thoughts. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidBurrows-NCO Yes, you are correct about sourcing config.fcst -- that's the way to go about it rather than config.ufs.
I'm marking this as draft and blocked until C5 is usable again |
|
Thanks for the heads up @WalterKolczynski-NOAA |
Description
What: update resources to run global-workflow C768C384 GSI on Gaea-C5.
Why: requested new feature from GSL
Resolves #2983
Type of change
Change characteristics
How has this been tested?
Checklist