Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI testing on AWS and other CSPs #3080

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

weihuang-jedi
Copy link
Contributor

Description

Enable CI testing on AWs and other CSPs

Resolves #3079

Type of change

  • Bug fix (fixes something broken)
  • [x ] New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow <!-- NOAA-EMC/wxflow#1234

How has this been tested?

Use this PR to start test on AWS.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me as long as it does what it needs to on CSPs.

env/AWSPW.env Outdated Show resolved Hide resolved
ush/load_fv3gfs_modules.sh Fixed Show fixed Hide fixed
@TerrenceMcGuinness-NOAA
Copy link
Collaborator

@weihuang-jedi The build_all.sh in this branch needs run with exit 0 or the CI pipeline will fail.

@weihuang-jedi weihuang-jedi marked this pull request as draft November 8, 2024 21:33
@weihuang-jedi
Copy link
Contributor Author

This is only to used as prototype to test CI on AWS.
Do not review, or try to merge it.

@TerrenceMcGuinness-NOAA
Copy link
Collaborator

OK, just touched base with Wie and we understand that this PR is mostly for edification for the time being.

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added the CI/CD Issue related to CI/CD label Nov 13, 2024
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Issue related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable CI testing on AWS and other CSPs
3 participants