Refactoring and fixing issues with job requests types #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaraney
previously approved these changes
Mar 20, 2023
| new_obj._memory_size = memory | ||
| new_obj._allocation_paradigm = paradigm | ||
| new_obj._allocation_priority = priority | ||
| #new_obj._cpu_count = cpus |
There was a problem hiding this comment.
Looks like these comments can be removed?
There was a problem hiding this comment.
I've cleaned those up now.
robertbartel
force-pushed
the
f/refactor_fix_jobs_requests/isolated
branch
2 times, most recently
from
934adb4
to
524a89c
Compare
Modifying class supertype, then updating __init__ and adding necessary properties.
- Updating class __init__ to require params previously taken from (already present) job_request param to conform to standard pattern used in class hierarchies - Adding convenience class method to factory create an instance with just the originating message, which __init__ previously did - Updating deserialization to account for above changes
Updating interface definition and existing implementation of job manager create_job function to have a fixed, required 'request' parameter of a type extending DmodJobRequest.
Updating dmod.client to depend on dmod.communication>=0.11.0.
Fixing init to properly handle args passed to super init.
Make sure value from passed model_request is used if no explicit 'config_data_id' is passed, while also ensuring an explicit value matches if it is provided.
robertbartel
force-pushed
the
f/refactor_fix_jobs_requests/isolated
branch
from
f7c7ee3
to
a4a7b50
Compare
aaraney
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_jobin JobManager interface and implementations to expect a DmodJobRequestNote that this supersedes #277. It is essentially the same change set rebased onto the current master commit.