Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in ModelExecRequestHandler post #503 #514

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Jan 31, 2024

Fix regression in ModelExecRequestHandler post #503

dmod.externalrequests -- 0.5.1

Changes

Testing

  1. Fixes NWM integration tests.

@aaraney
Copy link
Member Author

aaraney commented Jan 31, 2024

This fixes the errors we are seeing in the master branch's integration tests.

FAILED python/lib/externalrequests/dmod/test/it_model_exec_request_handler.py::IntegrationTestNWMRequestHandler::test_handle_request_2_a - TypeError: RequestClient.__init__() missing 1 required keyword-only argument: 'transport_client'
FAILED python/lib/externalrequests/dmod/test/it_model_exec_request_handler.py::IntegrationTestNWMRequestHandler::test_handle_request_2_b - TypeError: RequestClient.__init__() missing 1 required keyword-only argument: 'transport_client'
FAILED python/lib/externalrequests/dmod/test/it_model_exec_request_handler.py::IntegrationTestNWMRequestHandler::test_handle_request_2_c - TypeError: RequestClient.__init__() missing 1 required keyword-only argument: 'transport_client'
FAILED python/lib/externalrequests/dmod/test/it_model_exec_request_handler.py::IntegrationTestNWMRequestHandler::test_handle_request_2_d - TypeError: RequestClient.__init__() missing 1 required keyword-only argument: 'transport_client'
FAILED python/lib/externalrequests/dmod/test/it_model_exec_request_handler.py::IntegrationTestNWMRequestHandler::test_handle_request_2_e - TypeError: RequestClient.__init__() missing 1 required keyword-only argument: 'transport_client'
FAILED python/lib/externalrequests/dmod/test/it_model_exec_request_handler.py::IntegrationTestNWMRequestHandler::test_handle_request_3_a - TypeError: RequestClient.__init__() missing 1 required keyword-only argument: 'transport_client'
FAILED python/lib/externalrequests/dmod/test/it_model_exec_request_handler.py::IntegrationTestNWMRequestHandler::test_handle_request_3_b - TypeError: RequestClient.__init__() missing 1 required keyword-only argument: 'transport_client'
FAILED python/lib/externalrequests/dmod/test/it_model_exec_request_handler.py::IntegrationTestNWMRequestHandler::test_handle_request_3_c - TypeError: RequestClient.__init__() missing 1 required keyword-only argument: 'transport_client'
FAILED python/lib/externalrequests/dmod/test/it_model_exec_request_handler.py::IntegrationTestNWMRequestHandler::test_handle_request_3_d - TypeError: RequestClient.__init__() missing 1 required keyword-only argument: 'transport_client'
FAILED python/lib/externalrequests/dmod/test/it_model_exec_request_handler.py::IntegrationTestNWMRequestHandler::test_handle_request_3_e - TypeError: RequestClient.__init__() missing 1 required keyword-only argument: 'transport_client'

@robertbartel robertbartel merged commit 08498d2 into NOAA-OWP:master Feb 2, 2024
4 of 8 checks passed
@aaraney
Copy link
Member Author

aaraney commented Feb 5, 2024

Thanks for reviewing and merging this, @robertbartel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants