Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to run the JEDI LETKF DA in land-offline_workflow #37

Open
wants to merge 109 commits into
base: develop
Choose a base branch
from

Conversation

tsga
Copy link
Collaborator

@tsga tsga commented Nov 21, 2024

Describe your changes

Adds capability to run LETKF DA (full ensembles) in the land offline workflow. The codes for the other DA methods 2DVar and LETKF-OI remain the same (and old tests works as they are). The changes from these PRs are preparing input files for JEDI letkf (and vector to tile, add jedi increment) executables in ensemble form.

A submodule for generating ensemble forcing using the Stochastic Physics module is added here (https://github.com/tsga/stochastic_physics/tree/lnd_ens)

Related PRs

Test output

This PR doesn't change the current tests and it passes the 2DVar (GHCN + IMS) test

Additional test set for LETKF with 20 ensemble members prepared.

Checklist before requesting a review

  • My branch being merged is up to date with the latest develop.
  • I have performed a self-review of my code by examining the differences that will be merged.
  • I have not made any unnecessary code changes / changed any default behavior.
  • My code passes the DA_IMS_test, or differences can be explained.

Copy link
Collaborator

@ClaraDraper-NOAA ClaraDraper-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove all the directory values that are pointing to your directories?

For output directories, we can set a default using $USER. For input directories, any necessary data should be in either my DA_test_cases or on the LAND directory.

.gitmodules Show resolved Hide resolved
STOCHY/RESTART/stochy_final_ens9.nc Outdated Show resolved Hide resolved
check_test.sh Outdated Show resolved Hide resolved
ens_da/generate_ens_forc.nml Outdated Show resolved Hide resolved
ens_da/submit_cycle_letkf.sh Outdated Show resolved Hide resolved
ens_da/submit_cycle_letkf.sh Outdated Show resolved Hide resolved
ens_da/submit_cycle_letkf.sh Outdated Show resolved Hide resolved
ens_da/submit_cycle_letkf.sh Outdated Show resolved Hide resolved
@tsga tsga force-pushed the feature/lnd_ens branch from a118ec4 to f0bcdd8 Compare January 5, 2025 12:52
@tsga tsga requested a review from ClaraDraper-NOAA January 5, 2025 18:14
@tsga
Copy link
Collaborator Author

tsga commented Jan 5, 2025

Can you please remove all the directory values that are pointing to your directories?

For output directories, we can set a default using $USER. For input directories, any necessary data should be in either my DA_test_cases or on the LAND director

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants