Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Downloader class to have a specific PoDP downloader #121

Closed
5 tasks done
Tracked by #163
gcroci2 opened this issue Mar 3, 2023 · 0 comments · Fixed by #138 or #143
Closed
5 tasks done
Tracked by #163

Refactor Downloader class to have a specific PoDP downloader #121

gcroci2 opened this issue Mar 3, 2023 · 0 comments · Fixed by #138 or #143
Assignees
@CunliangGeng @gcroci2
Labels
GEN genomics related issues

Comments

@gcroci2
Copy link
Contributor

gcroci2 commented Mar 3, 2023 •
edited by CunliangGeng
Loading

Right now, src/nplinker/pairedomics/downloader.py contains the Downloader class which is basically a PoDP downloader, and not a general one.

  • rename class Downloader to PODPDownloader

Extract download code for different data source to independent modules

Move non-download functionalities out of PODPDownloader

The downloading is handled by class DatasetArranger
@gcroci2 gcroci2 added the GEN genomics related issues label Mar 3, 2023
@gcroci2 gcroci2 mentioned this issue Mar 3, 2023
Closed
@gcroci2 gcroci2 mentioned this issue Mar 15, 2023
Merged
This was referenced Apr 4, 2023
Merged
Closed
@gcroci2 gcroci2 linked a pull request May 12, 2023 that will close this issue
refactor: use refactored antismash downloader module in PODPDownloader class #138
Merged
@gcroci2 gcroci2 closed this as completed Jun 8, 2023
@gcroci2 gcroci2 reopened this Jun 8, 2023
@gcroci2 gcroci2 linked a pull request Jun 19, 2023 that will close this issue
refactor: move non-download functionalities out of PODPDownloader - _run_bigscape #143
Merged
@CunliangGeng CunliangGeng added this to dev Feb 16, 2024
@gcroci2 gcroci2 moved this to Ready in dev Feb 20, 2024
@CunliangGeng CunliangGeng moved this from Ready to Backlog in dev Feb 23, 2024
@CunliangGeng CunliangGeng moved this from Backlog to In progress in dev Feb 27, 2024
@CunliangGeng CunliangGeng mentioned this issue Feb 27, 2024
Closed
12 tasks
@CunliangGeng CunliangGeng self-assigned this Feb 27, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in dev Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CunliangGeng CunliangGeng

@gcroci2 gcroci2

Labels
GEN genomics related issues
Projects
dev
Status: Done
Milestone
No milestone
2 participants
@CunliangGeng @gcroci2