-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move non-download functionalities out of PODPDownloader
- _run_bigscape
#143
Conversation
…ntismash_downloader function
…ad_and_extract_antismash_data
Co-authored-by: Cunliang Geng <[email protected]>
Co-authored-by: Cunliang Geng <[email protected]>
Co-authored-by: Cunliang Geng <[email protected]>
Co-authored-by: Cunliang Geng <[email protected]>
Co-authored-by: Cunliang Geng <[email protected]>
Co-authored-by: Cunliang Geng <[email protected]>
Co-authored-by: Cunliang Geng <[email protected]>
Co-authored-by: Cunliang Geng <[email protected]>
Co-authored-by: Cunliang Geng <[email protected]>
Co-authored-by: Cunliang Geng <[email protected]>
Co-authored-by: Cunliang Geng <[email protected]>
Co-authored-by: Cunliang Geng <[email protected]>
In src/nplinker/pairedomics/runbigscape.py, |
Indeed, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally the download and run logics should be independent. To move run_bigscape out of PODPDownloader, we have to move the run logics to a higher level (i.e. to loader.py). Let's keep it as it is and really move it out when refactoring the loader part.
Sounds good, I mentioned it in the |
_run_bigscape
method has been moved to src/nplinker/pairedomics/runbigscape.py as a function and it is now calledpodp_run_bigscape
podp_run_bigscape