Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move non-download functionalities out of PODPDownloader - _run_bigscape #143

Merged
merged 48 commits into from
Jun 21, 2023

Conversation

gcroci2
Copy link
Contributor

@gcroci2 gcroci2 commented Jun 8, 2023

  • _run_bigscape method has been moved to src/nplinker/pairedomics/runbigscape.py as a function and it is now called podp_run_bigscape
  • src/nplinker/pairedomics/downloader.py now uses podp_run_bigscape
  • Type hints in src/nplinker/pairedomics/runbigscape.py have been added

gcroci2 and others added 30 commits April 6, 2023 10:28
@gcroci2 gcroci2 changed the base branch from dev to 137_refactored_antismash_in_podpdownloader_gcroci2 June 8, 2023 09:29
@gcroci2
Copy link
Contributor Author

gcroci2 commented Jun 8, 2023

In src/nplinker/pairedomics/runbigscape.py, run_bigscape takes as input extra_params, which to me appears to be a string. But then in the if __name__ == "__main__": statement, cutoffs=[0.3] is passed as extra_params parameter. Prospector indeed classifies it as an error, because it doesn't expect a cutoffs parameter.

@gcroci2 gcroci2 requested review from CunliangGeng and hechth June 8, 2023 09:53
@gcroci2 gcroci2 linked an issue Jun 19, 2023 that may be closed by this pull request
5 tasks
@CunliangGeng
Copy link
Member

In src/nplinker/pairedomics/runbigscape.py, run_bigscape takes as input extra_params, which to me appears to be a string. But then in the if __name__ == "__main__": statement, cutoffs=[0.3] is passed as extra_params parameter. Prospector indeed classifies it as an error, because it doesn't expect a cutoffs parameter.

Indeed, the extra_params is a string with space as separator.

Copy link
Member

@CunliangGeng CunliangGeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally the download and run logics should be independent. To move run_bigscape out of PODPDownloader, we have to move the run logics to a higher level (i.e. to loader.py). Let's keep it as it is and really move it out when refactoring the loader part.

Base automatically changed from 137_refactored_antismash_in_podpdownloader_gcroci2 to dev June 21, 2023 07:46
@gcroci2
Copy link
Contributor Author

gcroci2 commented Jun 21, 2023

Ideally the download and run logics should be independent. To move run_bigscape out of PODPDownloader, we have to move the run logics to a higher level (i.e. to loader.py). Let's keep it as it is and really move it out when refactoring the loader part.

Sounds good, I mentioned it in the DataLoader issue #145

@gcroci2 gcroci2 merged commit 31d9365 into dev Jun 21, 2023
@gcroci2 gcroci2 deleted the move_non_download_func_podpdownloader_gcroci2 branch June 21, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Downloader class to have a specific PoDP downloader
2 participants