Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow GCF loader to filter mibig-only GCF objects #171

Merged
merged 4 commits into from
Oct 31, 2023
Merged

allow GCF loader to filter mibig-only GCF objects #171

merged 4 commits into from
Oct 31, 2023

Conversation

CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Oct 25, 2023 •
edited
Loading

Major changes

  • add parameter keep_mibig_only to get_gcfs method for GCF loaders
  • update logics of checking mibig-only GCF

ℹ️ Tests have been checked locally. You can ignore the failed tests in github action.

@CunliangGeng CunliangGeng requested a review from gcroci2 October 25, 2023 15:01
@CunliangGeng CunliangGeng mentioned this pull request Oct 30, 2023
Merged
@CunliangGeng CunliangGeng merged commit f577e59 into dev Oct 31, 2023
2 of 4 checks passed
@CunliangGeng CunliangGeng deleted the add_gcf_filter branch October 31, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CunliangGeng @gcroci2