Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add magic method __add__ #173

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Add magic method __add__ #173

merged 3 commits into from
Oct 31, 2023

Conversation

CunliangGeng
Copy link
Member

Add magic method __add__ to StrainCollection class to enable the feature like sc_new = sc1 + sc2.

ℹ️ Tests have been checked locally. You can ignore the failed tests in github action.

- add the `__add__` magic method
-  add unit tests for this magic method
@CunliangGeng CunliangGeng requested a review from gcroci2 October 30, 2023 13:04
src/nplinker/strain_collection.py Outdated Show resolved Hide resolved
When using `from __future__ import annotations`, the class name can be directly used as type hint; Otherwise, use string like "ClassName" as type hint.
@CunliangGeng CunliangGeng merged commit 6c994b1 into dev Oct 31, 2023
0 of 2 checks passed
@CunliangGeng CunliangGeng deleted the add_magic_method_add branch October 31, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants