Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check format and typing only on changed files #238

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Apr 8, 2024

Update github actions to check code format and static typing only on changed files.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CunliangGeng and the rest of your teammates on Graphite Graphite

@CunliangGeng CunliangGeng requested a review from gcroci2 April 8, 2024 13:51
@CunliangGeng CunliangGeng self-assigned this Apr 8, 2024
Copy link
Contributor

@gcroci2 gcroci2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This doesn't prevent the checks to be run on not refactored files, though. We may exclude the files at the beginning of the yml file, but not sure if you want to do that.

.github/workflows/format-typing-check.yml Show resolved Hide resolved
Copy link
Member Author

CunliangGeng commented Apr 9, 2024

Merge activity

@CunliangGeng CunliangGeng merged commit 9dc315d into dev Apr 9, 2024
2 checks passed
@CunliangGeng CunliangGeng deleted the update_linter_action branch April 9, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants