Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove default config file to make all settings explicit #287

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Nov 27, 2024

A default config file nplinker_default.toml was used automatically in NPLinker. However, it may lead to two problems:

  1. The use of default settings cause confusions to users who might not be aware of them.
  2. It requires users to be familiar with Dynaconf to config their own settings

This PR removes the default config file and let users to config all settings in their config file nplinker.toml.

Copy link
Member Author

CunliangGeng commented Nov 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CunliangGeng CunliangGeng requested a review from gcroci2 November 27, 2024 14:31
@CunliangGeng CunliangGeng self-assigned this Nov 27, 2024
@CunliangGeng CunliangGeng linked an issue Nov 27, 2024 that may be closed by this pull request
@CunliangGeng CunliangGeng marked this pull request as ready for review November 27, 2024 14:31
Copy link
Member Author

CunliangGeng commented Nov 27, 2024

Merge activity

  • Nov 27, 11:20 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 27, 11:23 AM EST: Graphite rebased this pull request as part of a merge.
  • Nov 27, 11:24 AM EST: A user merged this pull request with Graphite.

@CunliangGeng CunliangGeng changed the base branch from add_support_mibigv4 to graphite-base/287 November 27, 2024 16:21
@CunliangGeng CunliangGeng changed the base branch from graphite-base/287 to dev November 27, 2024 16:21
@CunliangGeng CunliangGeng merged commit d9a4745 into dev Nov 27, 2024
3 of 4 checks passed
@CunliangGeng CunliangGeng deleted the add_config_auto branch November 27, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Use bigscape version in loaders
2 participants