Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove smiles prediction #289

Merged
merged 2 commits into from
Dec 11, 2024
Merged

remove smiles prediction #289

merged 2 commits into from
Dec 11, 2024

Conversation

CunliangGeng
Copy link
Member

we decided on the community meeting to remove SMILES prediction.

@CunliangGeng
remove smiles prediction
752655c 
we decided on the community meeting to remove SMILES prediction.
@CunliangGeng Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CunliangGeng CunliangGeng requested a review from gcroci2 December 4, 2024 16:14
@CunliangGeng CunliangGeng self-assigned this Dec 4, 2024
@CunliangGeng CunliangGeng marked this pull request as ready for review December 4, 2024 16:14
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

gcroci2
gcroci2 reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@gcroci2 gcroci2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you receive an OK for removing smiles completely (including the ones for mibig BGC)?

If yes, then we need to remove them from other files as well (src/nplinker/genomics/antismash/antismash_loader.py, src/nplinker/scoring/iokr/nplinker_iokr.py, etc.)

@CunliangGeng
Copy link
Member Author

yes, it's confirmed. I just removed that from BGC files. But I don't want to touch the iokr files, which should be changed in refactoring.

@gcroci2 gcroci2 mentioned this pull request Dec 6, 2024
Open
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Dec 11, 2024 •
edited
Loading

Merge activity

  • Dec 11, 4:01 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 11, 4:02 AM EST: A user merged this pull request with Graphite.

@CunliangGeng CunliangGeng merged commit 5515fdf into dev Dec 11, 2024
3 of 5 checks passed
@CunliangGeng CunliangGeng deleted the remove_smiles branch December 11, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees

@CunliangGeng CunliangGeng

Labels
None yet
Projects
dev
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CunliangGeng @gcroci2