Update PowerAnalytics for PSY4 compatibility #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jose Daniel Lara <[email protected]>
Make (old) PowerAnalytics work with PSY4
jd-lara
approved these changes
Jul 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 88.46% 88.23% -0.23%
==========================================
Files 3 3
Lines 312 323 +11
==========================================
+ Hits 276 285 +9
- Misses 36 38 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No major functionality changes, just accommodating the API changes in the other Sienna packages — this is not the big PowerAnalytics rewrite. Tests currently pass dependent on NREL-Sienna/HydroPowerSimulations.jl#34, leaving as draft until it's fully compatible with the released versions.