Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable speed PIUs: add example files fieldnames and revise error message #10776

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Variable speed PIUs: add example files fieldnames and revise error message #10776

merged 2 commits into from
Feb 6, 2025

Conversation

lymereJ
Copy link
Collaborator

@lymereJ lymereJ commented Sep 30, 2024

Pull request overview

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@lymereJ lymereJ added the Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring label Sep 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

⚠️ Regressions detected on macos-14 for commit 6f2b34f

Regression Summary
  • EIO: 1
  • ESO Big Diffs: 1
  • Table Big Diffs: 1
  • Table String Diffs: 1

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

⚠️ Regressions detected on macos-14 for commit e93e00f

Regression Summary
  • EIO: 1
  • ESO Big Diffs: 1
  • Table Big Diffs: 1
  • Table String Diffs: 1

@nrel-bot
Copy link

@lymereJ @Myoldmopar it has been 28 days since this pull request was last updated.

@nrel-bot-2
Copy link

@lymereJ it has been 24 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@lymereJ it has been 7 days since this pull request was last updated.

@Myoldmopar Myoldmopar self-assigned this Dec 4, 2024
@nrel-bot-2c
Copy link

@Myoldmopar @lymereJ it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@Myoldmopar @lymereJ it has been 9 days since this pull request was last updated.

@nrel-bot-2
Copy link

@Myoldmopar @lymereJ it has been 7 days since this pull request was last updated.

5 similar comments
@nrel-bot-2
Copy link

@Myoldmopar @lymereJ it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@Myoldmopar @lymereJ it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@Myoldmopar @lymereJ it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@Myoldmopar @lymereJ it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@Myoldmopar @lymereJ it has been 7 days since this pull request was last updated.

Myoldmopar
Myoldmopar approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@Myoldmopar Myoldmopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough. Quick check locally, but this seems ready.

@Myoldmopar
Copy link
Member

All happy, merging. Thanks @lymereJ

@Myoldmopar Myoldmopar merged commit 3d6e5b5 into develop Feb 6, 2025
10 checks passed
@Myoldmopar Myoldmopar deleted the add_test_files_fieldnames branch February 6, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Myoldmopar Myoldmopar Myoldmopar approved these changes

Assignees

@Myoldmopar Myoldmopar

Labels
Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lymereJ @nrel-bot @nrel-bot-2 @nrel-bot-2c @Myoldmopar @nrel-bot-2b