Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop new #130

Merged
merged 16 commits into from
Jan 8, 2024
Merged

Develop new #130

merged 16 commits into from
Jan 8, 2024

Conversation

AadilLatif
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@JKeen8 JKeen8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran these changes successfully in a cosim. I had to delete hardcoded file exports in both motor models:
self.file = open(r"C:\Users\alatif\Desktop\NAERM\models\17735\motor.csv", "w")

Also, there are a lot print statements I'm getting that look like this that we should probably remove:

PyDSS_5.Bus.1001458854_blv.puVmagAngle [0.7954920173250474, -121.48098708600301]
PyDSS_5.Bus.1001458901_blv.puVmagAngle [0.7941299022136167, -121.67780292375414]

@JKeen8
Copy link
Collaborator

JKeen8 commented Sep 28, 2023

@AadilLatif as we discussed and as shown in the attachment, the Exports.toml file in the defaults directory doesn't follow the new exports toml format that you created for this branch.
MicrosoftTeams-image (6)

@AadilLatif
Copy link
Collaborator Author

@AadilLatif as we discussed and as shown in the attachment, the Exports.toml file in the defaults directory doesn't follow the new exports toml format that you created for this branch. MicrosoftTeams-image (6)

fixed

@AadilLatif AadilLatif requested a review from daniel-thom October 5, 2023 15:39
@AadilLatif
Copy link
Collaborator Author

I ran these changes successfully in a cosim. I had to delete hardcoded file exports in both motor models: self.file = open(r"C:\Users\alatif\Desktop\NAERM\models\17735\motor.csv", "w")

Also, there are a lot print statements I'm getting that look like this that we should probably remove:

PyDSS_5.Bus.1001458854_blv.puVmagAngle [0.7954920173250474, -121.48098708600301] PyDSS_5.Bus.1001458901_blv.puVmagAngle [0.7941299022136167, -121.67780292375414]

fixed

@AadilLatif AadilLatif requested a review from JKeen8 October 6, 2023 15:33
@AadilLatif
Copy link
Collaborator Author

@AadilLatif as we discussed and as shown in the attachment, the Exports.toml file in the defaults directory doesn't follow the new exports toml format that you created for this branch. MicrosoftTeams-image (6)

fixed

@AadilLatif AadilLatif closed this Oct 9, 2023
@AadilLatif AadilLatif reopened this Oct 9, 2023
@AadilLatif AadilLatif merged commit d5e1f46 into master Jan 8, 2024
6 checks passed
@AadilLatif AadilLatif deleted the develop-new branch January 8, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants