-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.1.0 Defaults Updates and Hybrid+Central GHP #514
Conversation
adfarth
commented
Sep 29, 2023
•
edited by Bill-Becker
Loading
edited by Bill-Becker
- Annual default values update. See Defaults updates fy23 #513
- Add Hybrid and Central GHP in enable hybrid ghx #509
- Fix proforma metrics for GHP and add thermal results in Add GHP proforma metrics and BAU thermal results Redo #521
enable hybrid ghx and centralized ghp in REopt API v3
This reverts commit 39e7d1d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has both the FY23 defaults updates which we'll need to deploy at the same time as the web tool updates defaults, as well as the Hybrid and Central GHP which we need to merge Monday to still hit the FY23 milestone.
@lixiangk1 I missed this in the GHP PR review, but looks like we need to add Central GHP fields for ghpghx models.py GHPGHXInputs model. We should add a test for central GHP which would have caught this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lixiangk1 I think there needs to be Central GHP fields added to the GHPGHXInputs model in the ghpghx app and ideally add a test to confirm all GHPGHXInputs and GHPGHXOutputs are synced up with GhpGhx.jl - especially for central. I missed this in the PR into develop for GHP hybrid and central.
Debug central ghp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lixiangk1 made the updates for GHP, so approving this (again). We just need to sync with the web tool deploy for the defaults updates.
Add GHP proforma metrics and BAU thermal results Redo