Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.1.0 Defaults Updates and Hybrid+Central GHP #514

Merged
merged 56 commits into from
Oct 4, 2023
Merged

v3.1.0 Defaults Updates and Hybrid+Central GHP #514

merged 56 commits into from
Oct 4, 2023

Conversation

adfarth
Copy link
Collaborator

@adfarth adfarth commented Sep 29, 2023

Copy link
Collaborator

@Bill-Becker Bill-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has both the FY23 defaults updates which we'll need to deploy at the same time as the web tool updates defaults, as well as the Hybrid and Central GHP which we need to merge Monday to still hit the FY23 milestone.

@Bill-Becker Bill-Becker changed the title v3.1.0 Defaults Updates v3.1.0 Defaults Updates and Hybrid+Central GHP Oct 1, 2023
@Bill-Becker
Copy link
Collaborator

@lixiangk1 I missed this in the GHP PR review, but looks like we need to add Central GHP fields for ghpghx models.py GHPGHXInputs model. We should add a test for central GHP which would have caught this.

@Bill-Becker Bill-Becker self-requested a review October 2, 2023 02:50
Copy link
Collaborator

@Bill-Becker Bill-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lixiangk1 I think there needs to be Central GHP fields added to the GHPGHXInputs model in the ghpghx app and ideally add a test to confirm all GHPGHXInputs and GHPGHXOutputs are synced up with GhpGhx.jl - especially for central. I missed this in the PR into develop for GHP hybrid and central.

Copy link
Collaborator

@Bill-Becker Bill-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lixiangk1 made the updates for GHP, so approving this (again). We just need to sync with the web tool deploy for the defaults updates.

@Bill-Becker Bill-Becker merged commit 02fa6ab into master Oct 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants