-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proforma to API v3 #553
base: develop
Are you sure you want to change the base?
Conversation
Standalone python testing to create proforma and do negative testing
"\n", | ||
"inandout_sheet.write('B1', '', d['header_format_right'])\n", | ||
"\n", | ||
"inandout_sheet.write('B2', '', d['subheader_format_right'])\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could probably for-loop this section?
Summary of some initial testing:
|
@adfarth @Bill-Becker the branch now has proforma code integrated into it (i need to clean up the code a bit more). You can run a scenario, then supply its run_uuid to the new v3 proforma endpoint (GET), which returns an excel file of proforma in response. |
@rathod-b looks like the fractions vs percent is still an issue, where the values are fractions but they are being handled as percents in the equations which divide them by 100. Also, and I mostly expected this, but I ran a CHP case, and the boiler and CHP fuel costs are not being handled (zeros). I think this is an update that needs to come from the REopt.jl proforma script(s). |
remove extra functions and debug comments
resolve migration file conflict
tested end to end with new proforma endpoint
@Bill-Becker @adfarth Tested against 21 individual JSON files, most with success. TODO:
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
What is the current behavior?
(You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Other information: