-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back in explicit windows and mac testing #953
base: develop
Are you sure you want to change the base?
Conversation
Closing this one as seems like over-responding to one particular incident and greatly increasing our test count |
fwiw I think it's worth including Mac and Windows in the test matrix even if it's only for a subset. For example, you could run the example suite on all three systems but run the tests only on ubuntu. It would just be good to know that something is running on each OS. |
This feels like a reasonable compromise (examples only on ubuntu, since those take a while, and tests on all three OSs, since those are faster). I'll reopen the PR and make those updates. |
After readding macOS and windows tests, it appears that the only failing tests are on Windows using python 3.9; and moreover, they are all related to using parallel operations (most are explicit, but note that So, there are a couple of options here:
|
Just a heads up @misi9170 that a description of the issue is at #951 (comment). Based on their response, it looks like like @RHammond2 agrees with requiring Python 3.10+. I could go either way on that. In addition to the suggestions above, here are some more ways around this:
|
I prefer dropping 3.9, it's kind of a pain for reasons beyond those in this issue. Sometimes tests crash just for 3.9 and it's because you need to add that |
@rafmudaf, yes, I fully recommend moving to 3.10+. I've already moved a couple projects to 3.10+ at this point because 3.9 is out the door this year anyway, and it was causing some nuisance issues that were hard to resolve. Also, 3.10 introduces |
This is probably only a draft pull request, I was curious to see if it could help shed light on on #951. Adding windows os (and mac) back into CI OS testing matrix