Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a parser for multi query files #236

Open
jhoshiko opened this issue May 21, 2024 · 1 comment
Open

Create a parser for multi query files #236

jhoshiko opened this issue May 21, 2024 · 1 comment
Labels
enhancement New feature or request python Applies to the python code

Comments

@jhoshiko
Copy link
Collaborator

While tackling issue #209 (addressed in pr #228), we realized that it would be nice to create a parser for reading in queries from a multi query file. This pr is functional, but if a bracket is missing from a single query, the file pointer will keep reading lines and eventually crash unable to resolve the bad query. Ideally, this parser would catch this error before the crash and return a meaningful error. This will also allow us to verify the integrity of a query file before attempting to run the queries with a CompassApp.

@jhoshiko jhoshiko added enhancement New feature or request python Applies to the python code labels May 21, 2024
@zenon18
Copy link
Contributor

zenon18 commented May 21, 2024

Also once this is done, an example on how to use run_in_batches should be in the query_notebook that will be create in #212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Applies to the python code
Projects
None yet
Development

No branches or pull requests

2 participants