209 run in batches #228
Open
209 run in batches #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoshiko
reviewed
May 21, 2024
| @@ -135,6 +135,55 @@ def run( | |||
| return results[0] | |||
| return results | |||
|
|
|||
| def run_in_batches( | |||
| self, fp: TextIO, batch_size: int | |||
There was a problem hiding this comment.
Instead of passing a file pointer, let's instead pass a Path or string and then create the file pointer in this method.
|
After discussing this feature with the group, it sounds like we should look into adding a parser for query files to prevent crashes from faulty files (See issue #236) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for #209
Created a generator function that takes a file pointer and a batch size and reads up to that many queries from the file and calls run.