Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds in new routee powertrain models from recent training runs #256

Closed
wants to merge 5 commits into from

Conversation

nreinicke
Copy link
Collaborator

Adds in a host of new RouteE Powertrain models from a recent training batch.

This brings up a question though: Should we be hosting these binary models in the git repository or would it be cleaner to have them downloaded from a public box folder? The new set of models is about 30MB and if we're updating these frequently, the load on the repository could be high.

@nreinicke
Copy link
Collaborator Author

based on an IRL discussion, we should indeed move these files out of the git repo into something else (tbd what that something else is). maybe a git submodule that holds all of the models (for both compass and powertrain)

@nreinicke nreinicke marked this pull request as draft December 3, 2024 22:48
@nreinicke nreinicke marked this pull request as ready for review December 9, 2024 20:59
@nreinicke
Copy link
Collaborator Author

@robfitzgerald - I've updated this a bit such that now, only three default models are stored in the git repository (one from each category of ICE, BEV, PHEV). The remaining models are stored in an external box folder and will be downloaded (and cached) when building a compass dataset on the user side. This mirrors the workflow for hosting models from RouteE Powertrain. Eventually I could see us moving to a more robust, versioned approach to this (maybe DVC with an s3 remote?) but for now this allows us to reduce the overhead the models impose on the git history.

@nreinicke
Copy link
Collaborator Author

nreinicke commented Dec 12, 2024

These changes has been folded into #268 and so please reference that PR

@nreinicke nreinicke closed this Dec 12, 2024
@nreinicke nreinicke deleted the ndr/add-new-models branch December 12, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant