Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish adding mypy types #261

Merged
merged 24 commits into from
Dec 10, 2024
Merged

Finish adding mypy types #261

merged 24 commits into from
Dec 10, 2024

Conversation

nreinicke
Copy link
Collaborator

@nreinicke nreinicke commented Dec 9, 2024

Completes the work started by @SnoopJ to add the remaining mypy types and set up mypy to run in strict mode.

Closes #227
Closes #214

Copy link
Collaborator

@robfitzgerald robfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome. thanks @nreinicke and @SnoopJ ! 🎸

@nreinicke nreinicke merged commit 5e9002a into main Dec 10, 2024
5 checks passed
@nreinicke nreinicke deleted the ndr/finish-mypy-types branch December 10, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish adding mypy type checking
3 participants