Run simulation command in CI with consistent seed #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeannielynnmoulton
force-pushed
the
jeannie/useConsistentSeed
branch
14 times, most recently
from
ed9c62a to
ed052ef
Compare
jeannielynnmoulton
changed the title
jeannielynnmoulton
force-pushed
the
jeannie/runningInstructions
branch
from
12ce1b7 to
ceb5c93
Compare
jeannielynnmoulton
force-pushed
the
jeannie/useConsistentSeed
branch
from
ed052ef to
028372b
Compare
jeannielynnmoulton
changed the base branch from
main
to
jeannie/useConsistentSeedWithMoreTests
jeannielynnmoulton
force-pushed
the
jeannie/useConsistentSeed
branch
3 times, most recently
from
3eee9e8 to
6cb51ac
Compare
jeannielynnmoulton
force-pushed
the
jeannie/useConsistentSeedWithMoreTests
branch
from
9d873c0 to
1f41901
Compare
jeannielynnmoulton
force-pushed
the
jeannie/useConsistentSeed
branch
from
6cb51ac to
178ef5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a seed file option, so we can set the seed consistently. This PR just documents it, adds a sample seed file and runs the command with it in CI.
There were a few compilation issues when running on github actions which are fixed as part of this PR. C++ experts are encouraged to comment on the filesystem issue.This now depends on #22 for the compilation fix, so can be merged when PR 22 is merged. Make sure to change the base branch to main first.