Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EESA-#1 Bulletin crash after selecting tag filter #2

Merged
merged 1 commit into from
May 6, 2022

Conversation

redxouls
Copy link
Contributor

@redxouls redxouls commented May 6, 2022

What is this PR for?

I have already fix the bug

What type of PR is it?

Bug Fix

Todos

  • try to locate where the bug happened
  • [ ] resolve

What is the Github issue?

#1

How should this be tested?

Steps to reproduce the behavior:

  1. Go to "消息公告"
  2. Click on select
  3. Click on 公告
  4. No error

Screenshots (if appropriate)

Not yet

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

Copy link
Contributor Author

@redxouls redxouls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug message should be disabled.

@@ -87,6 +87,7 @@ export default class Bulletin extends React.Component {

render() {
const data = this.props.data
console.log(data)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to delete debug message.

@redxouls redxouls merged commit 6566fd4 into NTUEEInfoDep:main May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant