Sped up the time for entering pair research tasks by removing "popular tasks" feature #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove poetic:materialize-scss and use materialize-css from NPM instead
-removes meteorhacks:ssr, and adds a blaze-based SSR solution for email templates
seems to break if both galaxy and moniti perf monitoring are enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Delays in pair research were observed in #37, and we found that that a feature for showing "popular tasks" as you enter pair research was causing these large delays.
Specifically, this feature subscribes to task history and computes in the client some keywords about what people are working on. This request for data can cause major latency.
To fix this, I commented out the subscriptions to task history, and commented out the feature for computing popular tasks.
Testing: The results are that entering the pool is much faster, and less data is being sent over DDP subscriptions.
Also, we made sure the task history has updated on the DB, despite the subscription to task history being commented out.