Add scrolling photo bar (#9) #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add static photobar component with development placeholders * add scrolling animation (currently hardcoded duration and rotation) * increase gap between photos; add classes for slight left/right rotations * remove margins for h3 * remove absolute positioning * add header for photo bar; make photos hyperlinks; import and loop over people for photos * add inline styling to dynamically adjust animation length based on number of people * rename timePerPerson to secondsPerPerson * remove margins for text elements; standardize photo width/height; change animation timing function to linear; position photo bar above footer * add photo bar * adjust padding values * add people data file for photo bar --------- Co-authored-by: Darin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add static photobar component with development placeholders
add scrolling animation (currently hardcoded duration and rotation)
increase gap between photos; add classes for slight left/right rotations
remove margins for h3
remove absolute positioning
add header for photo bar; make photos hyperlinks; import and loop over people for photos
add inline styling to dynamically adjust animation length based on number of people
rename timePerPerson to secondsPerPerson
remove margins for text elements; standardize photo width/height; change animation timing function to linear; position photo bar above footer
add photo bar
adjust padding values
add people data file for photo bar