[logging] remove spdlog submodule which resolves many issues #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 7, 2020 12:51
1. add simple logger implementation without spdlog 2. update all modules to use new logger interface
tijyojwad
changed the title
ahehn-nv
requested changes
Dec 9, 2020
common/base/include/claraparabricks/genomeworks/logging/logging.hpp
Outdated
Show resolved
Hide resolved
common/base/include/claraparabricks/genomeworks/logging/logging.hpp
Outdated
Show resolved
Hide resolved
common/base/include/claraparabricks/genomeworks/logging/logging.hpp
Outdated
Show resolved
Hide resolved
common/base/include/claraparabricks/genomeworks/logging/logging.hpp
Outdated
Show resolved
Hide resolved
common/base/include/claraparabricks/genomeworks/utils/allocator.hpp
Outdated
Show resolved
Hide resolved
common/base/include/claraparabricks/genomeworks/utils/allocator.hpp
Outdated
Show resolved
Hide resolved
1. update logger api to use const char* 2. removed exit from critical logging state
|
rerun tests |
ahehn-nv
reviewed
Dec 10, 2020
common/base/include/claraparabricks/genomeworks/logging/logging.hpp
Outdated
Show resolved
Hide resolved
ahehn-nv
requested changes
Dec 10, 2020
ahehn-nv
requested changes
Dec 14, 2020
There was a problem hiding this comment.
Sorry, for the long wait. In addition to this last (I promise! ;) ) requested change, I still see a potential problem. I wanted to test this before I approve, but I haven't gotten around to it yet, so I will ignore that for the PR. I'll test it later and open a ticket if it turns out to be a problem.
ahehn-nv
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove spdlog as logger and replace with simple logging implementation.