Correct nvimagecodec version in conda and in installation instruction message

[jantonguirao]

Category:

Bug fix

Description:

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

• Existing tests apply
• New tests added
  • Python tests
  • GTests
  • Benchmark
  • Other
• N/A

Checklist

Documentation

• Existing documentation applies
• Documentation updated
  • Docstring
  • Doxygen
  • RST
  • Jupyter
  • Other
• N/A

DALI team only

Requirements

• Implements new requirements
• Affects existing requirements
• N/A

REQ IDs: N/A

JIRA TASK: N/A

[jantonguirao]

!build

[dali-automaton]

CI MESSAGE: [20404509]: BUILD STARTED

[stiepan]

Here there's the ${CUDA_MAJOR_VERSION} in the error message too.

[jantonguirao]

Fixed

[dali-automaton]

CI MESSAGE: [20404509]: BUILD PASSED

[jantonguirao]

it is pulled as a dependency automatically, so no need for this sentence.

[dali-automaton]

CI MESSAGE: [20431946]: BUILD STARTED

[stiepan]

Looks good!

I got a rather generic nitpick that the build version included in package versioning is fully recognized by pypi, so what the message tells the user now is not 100% accurate, but maybe good enough. And hopefully, with the explicit dependency it is not a message we expect people to see often.

DALI requires nvImageCodec at minimum version 0.3.0, but got 0.2.0. Please upgrade: See https://developer.nvidia.com/nvimgcodec-downloads or simply do `pip install nvidia-nvimgcodec-cu12==0.3.0`.
Current pipeline object is no longer valid.

but

>>> pip install nvidia-nvimgcodec-cu12==0.3.0
ERROR: Could not find a version that satisfies the requirement nvidia-nvimgcodec-cu12==0.3.0 (from versions: 0.2.0.7, 0.3.0.5, 0.4.0.9)
ERROR: No matching distribution found for nvidia-nvimgcodec-cu12==0.3.0

[JanuszL]

Looks good!

I got a rather generic nitpick that the build version included in package versioning is fully recognized by pypi, so what the message tells the user now is not 100% accurate, but maybe good enough. And hopefully, with the explicit dependency it is not a message we expect people to see often.

DALI requires nvImageCodec at minimum version 0.3.0, but got 0.2.0. Please upgrade: See https://developer.nvidia.com/nvimgcodec-downloads or simply do `pip install nvidia-nvimgcodec-cu12==0.3.0`.
Current pipeline object is no longer valid.

but

>>> pip install nvidia-nvimgcodec-cu12==0.3.0
ERROR: Could not find a version that satisfies the requirement nvidia-nvimgcodec-cu12==0.3.0 (from versions: 0.2.0.7, 0.3.0.5, 0.4.0.9)
ERROR: No matching distribution found for nvidia-nvimgcodec-cu12==0.3.0

Maybe it should be pip install nvidia-nvimgcodec-cu12>=0.3.0 ?

[stiepan]

Looks good!
I got a rather generic nitpick that the build version included in package versioning is fully recognized by pypi, so what the message tells the user now is not 100% accurate, but maybe good enough. And hopefully, with the explicit dependency it is not a message we expect people to see often.

DALI requires nvImageCodec at minimum version 0.3.0, but got 0.2.0. Please upgrade: See https://developer.nvidia.com/nvimgcodec-downloads or simply do `pip install nvidia-nvimgcodec-cu12==0.3.0`.
Current pipeline object is no longer valid.

but

>>> pip install nvidia-nvimgcodec-cu12==0.3.0
ERROR: Could not find a version that satisfies the requirement nvidia-nvimgcodec-cu12==0.3.0 (from versions: 0.2.0.7, 0.3.0.5, 0.4.0.9)
ERROR: No matching distribution found for nvidia-nvimgcodec-cu12==0.3.0

Maybe it should be pip install nvidia-nvimgcodec-cu12>=0.3.0 ?

I don't think so, that would install the most recent version (AFAIK pip does take into account installed packages requirements at this point), which may be incompatible.

What we probably could do is to include the patch version there, I think it is available in the header consumed at the built time.

[stiepan]

Oh but wait, there's "compatible version" equality! pip install nvidia-nvimgcodec-cu12~=0.3.0

https://packaging.python.org/en/latest/specifications/version-specifiers/#compatible-release
https://docs.conda.io/projects/conda-build/en/latest/resources/package-spec.html#package-match-specifications

[dali-automaton]

CI MESSAGE: [20431946]: BUILD PASSED