Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

call #268

Open
wants to merge 236 commits into
base: dev
Choose a base branch
from
Open

call #268

wants to merge 236 commits into from

Conversation

gshennvm
Copy link
Collaborator

What does this PR do ?

call train prep so the micro batches are calculated properly

jiemingz and others added 30 commits December 16, 2023 19:52
@jiemingz
add trtllm support
5e67140 
Signed-off-by: jiemingz <[email protected]>
@jiemingz
dataloader reshard
d955bb4 
Signed-off-by: jiemingz <[email protected]>
cleanup code and support trtllm 0.7
f75ae54 
Signed-off-by: jiemingz <=>
cleanup and sync with nemo exprot
25d8aae 
Signed-off-by: Jimmy Zhang <[email protected]>
remove resharding
5aa9dd4 
Signed-off-by: Jimmy Zhang <[email protected]>
fix topp and refactor
ac8933c 
Signed-off-by: jiemingz <=>
clamp tokens
f023c7d 
Signed-off-by: jiemingz <=>
resharding PP support
46828bf 
Signed-off-by: jiemingz <=>
@gshennvm
add mbs support
8d50946 
Signed-off-by: Gerald Shen <[email protected]>
Added nondivisible batch support on critic
0a0893a 
Signed-off-by: jiemingz <=>
@gshennvm
format only
c25cf6e 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
log prob batch
36f9664 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
fix
e52a35d 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
debug
1ae9987 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
fix
60aaecb 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
test
d68ed96 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
dummy
b2bfa6f 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
fix
297255d 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
fix
d4910b7 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
restore critic
4a52afe 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
fix
2140f36 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
add logging
e7ea083 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
fix critic client
6cd8923 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
fix
887874d 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
fix
6e2ca2d 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
fix
bacd786 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
fix
17b04ca 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
fix typo
9fee58b 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
better train timing
61ba204 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
remove prints
c9dad2a 
Signed-off-by: Gerald Shen <[email protected]>
gshennvm and others added 21 commits July 14, 2024 16:24
@gshennvm
fix
09d2783 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
fix
5105ed9 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
fix another bug
a2bf8a0 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
Merge remote-tracking branch 'origin/main' into geshen/trt_llm_to_main
d9d45d6
@gshennvm
update changelog
f00d09e 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
change rc version
d52eab2 
Signed-off-by: Gerald Shen <[email protected]>
@terrykong
Update the hash of the conversion script to include TE fix for mcore …
12fa459 
…conversion (#238)

Signed-off-by: Terry Kong <[email protected]>
@gshennvm
update docs
3d0a650 
Signed-off-by: Gerald Shen <[email protected]>
@terrykong
Addresses documentation bugs (#244)
e103759 
Signed-off-by: Terry Kong <[email protected]>
@terrykong @pre-commit-ci
Updates microbatch APIs to use megatron's instead of apex's (#241)
db3a9cc 
* Updates microbatch APIs to use megatron's instead of apex's

Signed-off-by: Terry Kong <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* take off protected prefix

Signed-off-by: Terry Kong <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Terry Kong <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@gshennvm
add pref
7dddeef 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm @terrykong
fix HF links in readme (#248)
cc26456 
Signed-off-by: Gerald Shen <[email protected]>
@terrykong
Point the TRTLLM documentation to Nemo docs (#257)
44701e5 
* Points to the documentation to the 0.4 branch

* update documentation to point to nemo docs

Signed-off-by: Terry Kong <[email protected]>

---------

Signed-off-by: Terry Kong <[email protected]>
@gshennvm
add scaling efficiency instead
a1f99fd 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
fix ending
e741e76 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
fix logic
e4ff1ec 
Signed-off-by: Gerald Shen <[email protected]>
@terrykong @jgerh
0.4 doc tech edit (#260)
46afc6b 
* Revert "add pref"

This reverts commit 7dddeef.

Signed-off-by: Terry Kong <[email protected]>

* Revert "update docs"

This reverts commit 3d0a650.

Signed-off-by: Terry Kong <[email protected]>

* revert steerlm2 docs

Signed-off-by: Terry Kong <[email protected]>

* revert rpo/ipo docs

Signed-off-by: Terry Kong <[email protected]>

* revert trtllm doc change on frontpage

Signed-off-by: Terry Kong <[email protected]>

* Update CHANGELOG.md to 0.4.0

Signed-off-by: Terry Kong <[email protected]>

* remove aview(-1)

Signed-off-by: Terry Kong <[email protected]>

* Addressing #260 (comment)

Signed-off-by: Terry Kong <[email protected]>

* apply next batch of suggestions

Signed-off-by: Terry Kong <[email protected]>

* applied suggestions in #260 (comment)

Signed-off-by: Terry Kong <[email protected]>

* appliying suggestions in #260 (comment)

Signed-off-by: Terry Kong <[email protected]>

* Update dpo.rst

Provided copyedits on file.

Signed-off-by: Terry Kong <[email protected]>

* Update index.rst

Added copyedits to the file.

Signed-off-by: Terry Kong <[email protected]>

* Update rlhf.rst

Copyedited the file.

Signed-off-by: Terry Kong <[email protected]>

* one space

Signed-off-by: Terry Kong <[email protected]>

* revert steerlm2 deletion

Signed-off-by: Terry Kong <[email protected]>

* restore rpo changes

Signed-off-by: Terry Kong <[email protected]>

* restore missing regression comment

Signed-off-by: Terry Kong <[email protected]>

* restore trtllm changeswq

Signed-off-by: Terry Kong <[email protected]>

* restore sterrlm2 in index.rst

Signed-off-by: Terry Kong <[email protected]>

* restore lost spacing

Signed-off-by: Terry Kong <[email protected]>

---------

Signed-off-by: Terry Kong <[email protected]>
Co-authored-by: jgerh <[email protected]>
@terrykong
Restore missing newline in performance table
9d5c71f 
Signed-off-by: Terry Kong <[email protected]>
@terrykong
fix rlhf perf table column headings
928d4a9 
Signed-off-by: Terry Kong <[email protected]>
@terrykong
Updates MBS calculator APIs to reconfigure_num_microbatches_calculator
384394f 
Which was introduced in this mcore commit: NVIDIA/Megatron-LM@32002bb

Signed-off-by: Terry Kong <[email protected]>
@gshennvm
call
7eb9a97 
Signed-off-by: Gerald Shen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrykong terrykong Awaiting requested review from terrykong

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Algorithms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gshennvm @jiemingz @terrykong