Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodelist flag to srun #410

Merged
merged 9 commits into from
Aug 30, 2024

Conversation

guyueh1
Copy link
Contributor

@guyueh1 guyueh1 commented Aug 13, 2024

This change adds a nodelist flag to conf/cluster/bcm.yaml. The nodelist flag, if specified, will be written to sbatch script. This is useful for clusters where specifying partition is broken and specifying nodelist is needed instead.

@guyueh1
Copy link
Contributor Author

guyueh1 commented Aug 26, 2024

@thomasdhc please review

@thomasdhc
Copy link
Collaborator

@guyueh1 Running tests now

@guyueh1
Copy link
Contributor Author

guyueh1 commented Aug 27, 2024

@thomasdhc could you test again, thanks

@guyueh1
Copy link
Contributor Author

guyueh1 commented Aug 30, 2024

@thomasdhc please review & test

Copy link
Collaborator

@thomasdhc thomasdhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Guyue Huang <[email protected]>
@guyueh1
Copy link
Contributor Author

guyueh1 commented Aug 30, 2024

Fix utest, making bcm utest consistent with conf/cluster/bcm.yaml.
Pls restart utest @thomasdhc

@thomasdhc thomasdhc merged commit f932a6e into NVIDIA:main Aug 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants