-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nodelist flag to srun #410
Merged
thomasdhc
merged 9 commits into
NVIDIA:main
from
guyueh1:guyueh/feat_cluster_specify_nodelist
Aug 30, 2024
Merged
Add nodelist flag to srun #410
thomasdhc
merged 9 commits into
NVIDIA:main
from
guyueh1:guyueh/feat_cluster_specify_nodelist
Aug 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guyue Huang <[email protected]>
@thomasdhc please review |
@guyueh1 Running tests now |
@thomasdhc could you test again, thanks |
@thomasdhc please review & test |
thomasdhc
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Guyue Huang <[email protected]>
Fix utest, making bcm utest consistent with |
Signed-off-by: Guyue Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a nodelist flag to conf/cluster/bcm.yaml. The nodelist flag, if specified, will be written to sbatch script. This is useful for clusters where specifying partition is broken and specifying nodelist is needed instead.