Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NeMo-UX] Support load_strictness #10612

Merged
merged 18 commits into from
Nov 26, 2024
Merged

[NeMo-UX] Support load_strictness #10612

merged 18 commits into from
Nov 26, 2024

Commits on Sep 23, 2024

  1. add load_strictness to nemo 2.0 

    Signed-off-by: ashors1 <[email protected]>
    @ashors1
    ashors1 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4be9bae View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. bug fix 

    Signed-off-by: ashors1 <[email protected]>
    @ashors1
    ashors1 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    54df253 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Revert "bug fix" 

    This reverts commit 54df253.
    @ashors1
    ashors1 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    13e5c81 View commit details
    Browse the repository at this point in the history

  2. Revert "add load_strictness to nemo 2.0" 

    This reverts commit 4be9bae.
    @ashors1
    ashors1 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    82c4eee View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. use 'strict' arg from PTL rather than adding another arg 

    Signed-off-by: ashors1 <[email protected]>
    @ashors1
    ashors1 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    40b39e9 View commit details
    Browse the repository at this point in the history

  2. Apply isort and black reformatting 

    Signed-off-by: ashors1 <[email protected]>
    @ashors1
    ashors1 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    7308b57 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Merge branch 'main' of github.com:NVIDIA/NeMo into ashors/nemo-ux-ckp… 

    …t-load-strictness
    @ashors1
    ashors1 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2d309cb View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. control mcore strict loading via an environment variable as a tempora… 

    …ry workaround

Signed-off-by: ashors1 <[email protected]>
    @ashors1
    ashors1 committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    0c1c9b2 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. pass ckpt_load_strictness to megatron strategy 

    Signed-off-by: ashors1 <[email protected]>
    @ashors1
    ashors1 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ddb968e View commit details
    Browse the repository at this point in the history

  2. Apply isort and black reformatting 

    Signed-off-by: ashors1 <[email protected]>
    @ashors1
    ashors1 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    001f1fd View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. address comments 

    Signed-off-by: ashors1 <[email protected]>
    @ashors1
    ashors1 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    fce7ecd View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. bug fix 

    Signed-off-by: ashors1 <[email protected]>
    @ashors1
    ashors1 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7450936 View commit details
    Browse the repository at this point in the history

  2. remove unused import 

    Signed-off-by: ashors1 <[email protected]>
    @ashors1
    ashors1 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    1c5a576 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. fix selective restore 

    Signed-off-by: ashors1 <[email protected]>
    @ashors1
    ashors1 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    304744a View commit details
    Browse the repository at this point in the history

  2. Apply isort and black reformatting 

    Signed-off-by: ashors1 <[email protected]>
    @ashors1
    ashors1 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    56a919f View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. fix selective restore 

    Signed-off-by: ashors1 <[email protected]>
    @ashors1
    ashors1 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    28d5846 View commit details
    Browse the repository at this point in the history

  2. Apply isort and black reformatting 

    Signed-off-by: ashors1 <[email protected]>
    @ashors1
    ashors1 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    b4ad6ef View commit details
    Browse the repository at this point in the history

  3. forward strict arg to peft 

    Signed-off-by: ashors1 <[email protected]>
    @ashors1
    ashors1 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    1188591 View commit details
    Browse the repository at this point in the history