Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sortformer Diarizer 4spk v1 model PR Part 1: models, modules and dataloaders #11282
base: main
Are you sure you want to change the base?
Sortformer Diarizer 4spk v1 model PR Part 1: models, modules and dataloaders #11282
Changes from 15 commits
e69ec8e
2914325
9a468ac
a910d30
2f44fe1
4ddc59b
43d95f0
40e9f95
f7f84bb
95acd79
919f4da
4134e25
d3432e5
5dd4d4c
ca5eea3
9d493c0
037f61e
a8bc048
cb23268
4a266b9
5e4e9c8
c31c60c
6e2225e
ab93b17
4f3ee66
3f24b82
f49e107
7dea01b
2a99d53
71d515f
9b7b93e
f2d5e36
9cca3e8
731caa8
681fe38
008dcbd
d89ed91
045f3a2
1dcf9ab
1360831
7893e75
f7fced9
9371ed0
6a3bb62
4e0327c
b8a49ea
6198a20
e4b0154
07c4242
0eeaf06
fa11155
b5878cc
bfe36e7
7898697
e167dba
1bb89d5
e4006cf
a92e4e6
ca480eb
5ea9d7d
1b091c8
af04832
a4367a3
edbe159
b47579b
8365a05
f2250a0
5275fb5
86315db
07f791a
2b23136
30f1159
f9a9884
0e50abf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo? optimized with
withThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why DIHARD3 instead of Callhome part 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optimized with
withThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like dihard3 is using Callhome parameters and Callhome is using dihard3 parameters. Also should the file name be sortformer_diar_4spk-v1_dihard
3
.-dev.yaml?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the swapped dataset names.
Fixed the file name with "3" included.