-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor chevron to cub #2069
base: main
Are you sure you want to change the base?
Refactor chevron to cub #2069
Conversation
CUB_NAMESPACE_BEGIN | ||
|
||
|
||
namespace detail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this namespace cocrrect? i see there's cuda_cub
in the thrust launcher
Those are independent things. You could create a new branch locally (with a different name) and force push it to the same branch in your fork, from which the PR was created. You could also just By creating a new PR, you create discontinuity in the review, especially because @gevtushenko already provided a lot of feedback on your old PR, some of which is unaddressed. |
Independently on where you want to continue your work, this PR seems to add a copy of Thrust's trivple_chevron into CUB. #568 seems to suggest to move the functionality instead, so it should no longer exist in Thrust. |
Yes, I did not remove Thrust's chevron here. That would be the next step. But I wasn't sure if this work was still required, so I decided to ask questions here first. Before progressing further I wanted to make sure this was still needed so I could avoid wasting my time in the case it wasn't. Sorry for not clarifying on that |
This work seems similar to #2038, so maybe @pciolkosz knows the answer to that. |
Thank you. I'll hold off on this one then for now |
I had a PR here
https://github.com/NVIDIA/cccl/pull/592/files that I forgot about. It would probably easier to just make a new PR instead of trying to rebase that one since it's old.
With that being said to ease burden on the reviewer I've only touched 1 file(for now) and left comments where I am asking questions. If this work isn't needed anymore LMK and I will close both PRs.
Checklist