Fix rst typos in benchmarking.html #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonidelis
requested review from
gevtushenko,
miscco and
bernhardmgruber
and removed request for
gevtushenko
gonidelis
force-pushed
the
cub_benchmarking_docs_fix
branch
from
aba9ac4 to
10f5d9a
Compare
With our devcontainers and presets dev environment it's highly likely that `cccl/` is not just a step above.
gonidelis
force-pushed
the
cub_benchmarking_docs_fix
branch
from
10f5d9a to
0163318
Compare
miscco
approved these changes
Nov 19, 2024
| @@ -181,7 +187,7 @@ We can then run the full benchmark suite from the build directory with: | |||
|
|
|||
| .. code-block:: bash | |||
|
|
|||
| ../benchmarks/scripts/run.py | |||
| <root_dir_to_cccl>/cccl/benchmarks/scripts/run.py | |||
There was a problem hiding this comment.
Remark: I wrote the documentation from the perspective of the cmake build directory. But I am not against the change, if this helps you (and users)!
bernhardmgruber
approved these changes
Nov 19, 2024
trxcllnt
pushed a commit
to trxcllnt/cccl
that referenced
this pull request
Nov 23, 2024
* Fix rst typos in benchmarking.html * typo * run.py script proper directory With our devcontainers and presets dev environment it's highly likely that `cccl/` is not just a step above. * Add `CUDA_VISIBLE_DEVICES` warning explanation so it can be avoided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes and extensions on top of #2831