Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix old gcc version check #2904

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix old gcc version check #2904

merged 1 commit into from
Nov 20, 2024

Conversation

davebayer
Copy link
Contributor

Fix old GCC version check introduced in #2518.

@davebayer davebayer requested review from a team as code owners November 20, 2024 06:14
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 20, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bernhardmgruber
Copy link
Contributor

/ok to test

@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 2h 27m: Pass: 100%/224 | Total: 2d 03h | Avg: 13m 51s | Max: 1h 39m | Hits: 99%/12288

  • 🟩 thrust: Pass: 100%/111 | Total: 22h 19m | Avg: 12m 04s | Max: 49m 48s | Hits: 99%/9260 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 41m 41s | Avg: 20m 50s | Max: 30m 00s
🟩 cpu
  🟩 amd64              Pass: 100%/103 | Total: 20h 13m | Avg: 11m 46s | Max: 49m 48s | Hits:  99%/9260  
  🟩 arm64              Pass: 100%/8   | Total:  2h 06m | Avg: 15m 47s | Max: 35m 53s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 19m | Avg:  5m 16s | Max: 19m 34s | Hits:  99%/1852  
  🟩 11.8               Pass: 100%/3   | Total:  1h 29m | Avg: 29m 54s | Max: 43m 11s
  🟩 12.5               Pass: 100%/4   | Total:  1h 00m | Avg: 15m 05s | Max: 16m 47s
  🟩 12.6               Pass: 100%/89  | Total: 18h 30m | Avg: 12m 28s | Max: 49m 48s | Hits:  99%/7408  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total: 21m 56s | Avg:  5m 29s | Max:  7m 56s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 19m | Avg:  5m 16s | Max: 19m 34s | Hits:  99%/1852  
  🟩 nvcc11.8           Pass: 100%/3   | Total:  1h 29m | Avg: 29m 54s | Max: 43m 11s
  🟩 nvcc12.5           Pass: 100%/4   | Total:  1h 00m | Avg: 15m 05s | Max: 16m 47s
  🟩 nvcc12.6           Pass: 100%/85  | Total: 18h 08m | Avg: 12m 48s | Max: 49m 48s | Hits:  99%/7408  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total: 21m 56s | Avg:  5m 29s | Max:  7m 56s
  🟩 nvcc               Pass: 100%/107 | Total: 21h 57m | Avg: 12m 19s | Max: 49m 48s | Hits:  99%/9260  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 33m 15s | Avg:  5m 32s | Max:  8m 08s
  🟩 Clang10            Pass: 100%/3   | Total: 18m 55s | Avg:  6m 18s | Max:  6m 29s
  🟩 Clang11            Pass: 100%/4   | Total: 21m 54s | Avg:  5m 28s | Max:  5m 55s
  🟩 Clang12            Pass: 100%/4   | Total: 20m 45s | Avg:  5m 11s | Max:  5m 30s
  🟩 Clang13            Pass: 100%/4   | Total: 22m 20s | Avg:  5m 35s | Max:  6m 11s
  🟩 Clang14            Pass: 100%/4   | Total: 20m 53s | Avg:  5m 13s | Max:  5m 37s
  🟩 Clang15            Pass: 100%/4   | Total: 21m 03s | Avg:  5m 15s | Max:  5m 44s
  🟩 Clang16            Pass: 100%/4   | Total: 21m 10s | Avg:  5m 17s | Max:  5m 44s
  🟩 Clang17            Pass: 100%/4   | Total: 20m 38s | Avg:  5m 09s | Max:  5m 14s
  🟩 Clang18            Pass: 100%/11  | Total:  1h 06m | Avg:  6m 04s | Max: 14m 22s
  🟩 GCC6               Pass: 100%/2   | Total:  8m 18s | Avg:  4m 09s | Max:  4m 21s
  🟩 GCC7               Pass: 100%/6   | Total: 27m 01s | Avg:  4m 30s | Max:  4m 57s
  🟩 GCC8               Pass: 100%/6   | Total: 28m 28s | Avg:  4m 44s | Max:  5m 24s
  🟩 GCC9               Pass: 100%/6   | Total:  1h 05m | Avg: 10m 57s | Max: 42m 42s
  🟩 GCC10              Pass: 100%/4   | Total:  1h 53m | Avg: 28m 24s | Max: 40m 15s
  🟩 GCC11              Pass: 100%/7   | Total:  3h 26m | Avg: 29m 25s | Max: 43m 11s
  🟩 GCC12              Pass: 100%/4   | Total:  2h 21m | Avg: 35m 18s | Max: 49m 48s
  🟩 GCC13              Pass: 100%/16  | Total:  5h 07m | Avg: 19m 13s | Max: 43m 01s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 19m 56s | Avg:  6m 38s | Max:  7m 24s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 19m 34s | Avg: 19m 34s | Max: 19m 34s | Hits:  99%/1852  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 30m 03s | Avg: 15m 01s | Max: 15m 27s | Hits:  99%/3704  
  🟩 MSVC14.39          Pass: 100%/2   | Total: 44m 20s | Avg: 22m 10s | Max: 28m 29s | Hits:  99%/3704  
  🟩 NVHPC24.7          Pass: 100%/4   | Total:  1h 00m | Avg: 15m 05s | Max: 16m 47s
🟩 cxx_family
  🟩 Clang              Pass: 100%/48  | Total:  4h 27m | Avg:  5m 34s | Max: 14m 22s
  🟩 GCC                Pass: 100%/51  | Total: 14h 57m | Avg: 17m 36s | Max: 49m 48s
  🟩 Intel              Pass: 100%/3   | Total: 19m 56s | Avg:  6m 38s | Max:  7m 24s
  🟩 MSVC               Pass: 100%/5   | Total:  1h 33m | Avg: 18m 47s | Max: 28m 29s | Hits:  99%/9260  
  🟩 NVHPC              Pass: 100%/4   | Total:  1h 00m | Avg: 15m 05s | Max: 16m 47s
🟩 gpu
  🟩 v100               Pass: 100%/111 | Total: 22h 19m | Avg: 12m 04s | Max: 49m 48s | Hits:  99%/9260  
🟩 jobs
  🟩 Build              Pass: 100%/103 | Total: 20h 39m | Avg: 12m 01s | Max: 49m 48s | Hits:  99%/7408  
  🟩 TestCPU            Pass: 100%/4   | Total: 51m 40s | Avg: 12m 55s | Max: 28m 29s | Hits:  99%/1852  
  🟩 TestGPU            Pass: 100%/4   | Total: 49m 06s | Avg: 12m 16s | Max: 14m 22s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  1h 29m | Avg: 29m 54s | Max: 43m 11s
  🟩 90a                Pass: 100%/4   | Total:  1h 09m | Avg: 17m 19s | Max: 22m 47s
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  2h 41m | Avg:  5m 22s | Max: 13m 28s
  🟩 14                 Pass: 100%/29  | Total:  6h 44m | Avg: 13m 56s | Max: 43m 23s | Hits:  99%/3704  
  🟩 17                 Pass: 100%/27  | Total:  5h 55m | Avg: 13m 08s | Max: 49m 48s | Hits:  99%/1852  
  🟩 20                 Pass: 100%/23  | Total:  6h 17m | Avg: 16m 24s | Max: 43m 01s | Hits:  99%/3704

  • 🟩 cub: Pass: 100%/110 | Total: 1d 05h | Avg: 15m 49s | Max: 1h 39m | Hits: 99%/3028 

    🟩 cpu
  🟩 amd64              Pass: 100%/102 | Total:  1d 01h | Avg: 15m 10s | Max:  1h 39m | Hits:  99%/3028  
  🟩 arm64              Pass: 100%/8   | Total:  3h 13m | Avg: 24m 13s | Max: 56m 25s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 16m | Avg:  5m 07s | Max: 14m 03s | Hits:  99%/757   
  🟩 11.8               Pass: 100%/3   | Total:  3h 27m | Avg:  1h 09m | Max:  1h 39m
  🟩 12.5               Pass: 100%/4   | Total: 37m 14s | Avg:  9m 18s | Max:  9m 42s
  🟩 12.6               Pass: 100%/88  | Total: 23h 39m | Avg: 16m 07s | Max:  1h 30m | Hits:  99%/2271  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total: 17m 11s | Avg:  4m 17s | Max:  4m 24s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 16m | Avg:  5m 07s | Max: 14m 03s | Hits:  99%/757   
  🟩 nvcc11.8           Pass: 100%/3   | Total:  3h 27m | Avg:  1h 09m | Max:  1h 39m
  🟩 nvcc12.5           Pass: 100%/4   | Total: 37m 14s | Avg:  9m 18s | Max:  9m 42s
  🟩 nvcc12.6           Pass: 100%/84  | Total: 23h 21m | Avg: 16m 41s | Max:  1h 30m | Hits:  99%/2271  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total: 17m 11s | Avg:  4m 17s | Max:  4m 24s
  🟩 nvcc               Pass: 100%/106 | Total:  1d 04h | Avg: 16m 15s | Max:  1h 39m | Hits:  99%/3028  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 32m 17s | Avg:  5m 22s | Max:  6m 35s
  🟩 Clang10            Pass: 100%/3   | Total: 18m 44s | Avg:  6m 14s | Max:  6m 24s
  🟩 Clang11            Pass: 100%/4   | Total: 21m 09s | Avg:  5m 17s | Max:  5m 41s
  🟩 Clang12            Pass: 100%/4   | Total: 20m 36s | Avg:  5m 09s | Max:  5m 18s
  🟩 Clang13            Pass: 100%/4   | Total: 21m 37s | Avg:  5m 24s | Max:  5m 36s
  🟩 Clang14            Pass: 100%/4   | Total: 20m 27s | Avg:  5m 06s | Max:  5m 08s
  🟩 Clang15            Pass: 100%/4   | Total: 22m 25s | Avg:  5m 36s | Max:  6m 17s
  🟩 Clang16            Pass: 100%/4   | Total: 20m 44s | Avg:  5m 11s | Max:  5m 20s
  🟩 Clang17            Pass: 100%/4   | Total: 21m 06s | Avg:  5m 16s | Max:  5m 21s
  🟩 Clang18            Pass: 100%/11  | Total:  1h 21m | Avg:  7m 26s | Max: 24m 40s
  🟩 GCC6               Pass: 100%/2   | Total:  8m 58s | Avg:  4m 29s | Max:  4m 43s
  🟩 GCC7               Pass: 100%/6   | Total: 29m 07s | Avg:  4m 51s | Max:  5m 32s
  🟩 GCC8               Pass: 100%/6   | Total: 30m 16s | Avg:  5m 02s | Max:  6m 00s
  🟩 GCC9               Pass: 100%/6   | Total: 29m 30s | Avg:  4m 55s | Max:  5m 53s
  🟩 GCC10              Pass: 100%/4   | Total:  2h 48m | Avg: 42m 07s | Max: 54m 37s
  🟩 GCC11              Pass: 100%/7   | Total:  6h 20m | Avg: 54m 19s | Max:  1h 39m
  🟩 GCC12              Pass: 100%/4   | Total:  2h 55m | Avg: 43m 50s | Max: 57m 37s
  🟩 GCC13              Pass: 100%/16  | Total:  8h 49m | Avg: 33m 03s | Max:  1h 30m
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 19m 26s | Avg:  6m 28s | Max:  6m 44s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 14m 03s | Avg: 14m 03s | Max: 14m 03s | Hits:  99%/757   
  🟩 MSVC14.29          Pass: 100%/2   | Total: 24m 28s | Avg: 12m 14s | Max: 12m 46s | Hits:  99%/1514  
  🟩 MSVC14.39          Pass: 100%/1   | Total: 13m 53s | Avg: 13m 53s | Max: 13m 53s | Hits:  99%/757   
  🟩 NVHPC24.7          Pass: 100%/4   | Total: 37m 14s | Avg:  9m 18s | Max:  9m 42s
🟩 cxx_family
  🟩 Clang              Pass: 100%/48  | Total:  4h 41m | Avg:  5m 51s | Max: 24m 40s
  🟩 GCC                Pass: 100%/51  | Total: 22h 30m | Avg: 26m 29s | Max:  1h 39m
  🟩 Intel              Pass: 100%/3   | Total: 19m 26s | Avg:  6m 28s | Max:  6m 44s
  🟩 MSVC               Pass: 100%/4   | Total: 52m 24s | Avg: 13m 06s | Max: 14m 03s | Hits:  99%/3028  
  🟩 NVHPC              Pass: 100%/4   | Total: 37m 14s | Avg:  9m 18s | Max:  9m 42s
🟩 gpu
  🟩 v100               Pass: 100%/110 | Total:  1d 05h | Avg: 15m 49s | Max:  1h 39m | Hits:  99%/3028  
🟩 jobs
  🟩 Build              Pass: 100%/102 | Total:  1d 00h | Avg: 14m 36s | Max:  1h 39m | Hits:  99%/3028  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 33m 00s | Avg: 33m 00s | Max: 33m 00s
  🟩 GraphCapture       Pass: 100%/1   | Total: 14m 42s | Avg: 14m 42s | Max: 14m 42s
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 09m | Avg: 23m 07s | Max: 36m 25s
  🟩 TestGPU            Pass: 100%/3   | Total:  2h 14m | Avg: 44m 48s | Max:  1h 30m
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  3h 27m | Avg:  1h 09m | Max:  1h 39m
  🟩 90a                Pass: 100%/4   | Total:  1h 18m | Avg: 19m 39s | Max: 25m 32s
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  3h 26m | Avg:  6m 53s | Max: 19m 18s
  🟩 14                 Pass: 100%/29  | Total:  7h 56m | Avg: 16m 26s | Max:  1h 39m | Hits:  99%/1514  
  🟩 17                 Pass: 100%/27  | Total:  7h 45m | Avg: 17m 13s | Max:  1h 37m | Hits:  99%/757   
  🟩 20                 Pass: 100%/24  | Total:  9h 52m | Avg: 24m 40s | Max:  1h 30m | Hits:  99%/757

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 9m 22s | Avg: 4m 41s | Max: 6m 59s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total:  9m 22s | Avg:  4m 41s | Max:  6m 59s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total:  9m 22s | Avg:  4m 41s | Max:  6m 59s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total:  9m 22s | Avg:  4m 41s | Max:  6m 59s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total:  9m 22s | Avg:  4m 41s | Max:  6m 59s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total:  9m 22s | Avg:  4m 41s | Max:  6m 59s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total:  9m 22s | Avg:  4m 41s | Max:  6m 59s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total:  9m 22s | Avg:  4m 41s | Max:  6m 59s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 23s | Avg:  2m 23s | Max:  2m 23s
  🟩 Test               Pass: 100%/1   | Total:  6m 59s | Avg:  6m 59s | Max:  6m 59s

  • 🟩 python: Pass: 100%/1 | Total: 14m 41s | Avg: 14m 41s | Max: 14m 41s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 14m 41s | Avg: 14m 41s | Max: 14m 41s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 14m 41s | Avg: 14m 41s | Max: 14m 41s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 14m 41s | Avg: 14m 41s | Max: 14m 41s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 14m 41s | Avg: 14m 41s | Max: 14m 41s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 14m 41s | Avg: 14m 41s | Max: 14m 41s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 14m 41s | Avg: 14m 41s | Max: 14m 41s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 14m 41s | Avg: 14m 41s | Max: 14m 41s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 14m 41s | Avg: 14m 41s | Max: 14m 41s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 224)
# Runner
185 linux-amd64-cpu16
16 linux-arm64-cpu16
14 linux-amd64-gpu-v100-latest-1
9 windows-amd64-cpu16

@bernhardmgruber bernhardmgruber merged commit d80ab66 into NVIDIA:main Nov 20, 2024
240 checks passed
@bernhardmgruber
Copy link
Contributor

Thx a lot for the fix!

trxcllnt pushed a commit to trxcllnt/cccl that referenced this pull request Nov 23, 2024
@davebayer @trxcllnt
fix old gcc version check (NVIDIA#2904)
b04fef5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernhardmgruber bernhardmgruber bernhardmgruber approved these changes

@alliepiper alliepiper Awaiting requested review from alliepiper alliepiper is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davebayer @bernhardmgruber